You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/23 08:22:31 UTC
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request
#4417: modify TableTokenGenerator
tristaZero opened a new pull request #4417: modify TableTokenGenerator
URL: https://github.com/apache/incubator-shardingsphere/pull/4417
Fixes #4416.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4417:
modify TableTokenGenerator
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4417: modify TableTokenGenerator
URL: https://github.com/apache/incubator-shardingsphere/pull/4417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4417: modify TableTokenGenerator
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4417: modify TableTokenGenerator
URL: https://github.com/apache/incubator-shardingsphere/pull/4417#issuecomment-590047721
## Pull Request Test Coverage Report for [Build 1844](https://coveralls.io/builds/28902033)
* **20** of **22** **(90.91%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.05%**) to **58.649%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/generator/impl/TableTokenGenerator.java](https://coveralls.io/builds/28902033/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FTableTokenGenerator.java#L123) | 20 | 22 | 90.91%
<!-- | **Total:** | **20** | **22** | **90.91%** | -->
| Totals | [](https://coveralls.io/builds/28902033) |
| :-- | --: |
| Change from base [Build 909](https://coveralls.io/builds/28901805): | 0.05% |
| Covered Lines: | 10836 |
| Relevant Lines: | 18476 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4417:
modify TableTokenGenerator
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4417: modify TableTokenGenerator
URL: https://github.com/apache/incubator-shardingsphere/pull/4417#issuecomment-590047721
## Pull Request Test Coverage Report for [Build 9720](https://coveralls.io/builds/28902010)
* **20** of **22** **(90.91%)** changed or added relevant lines in **1** file are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.04%**) to **58.644%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/generator/impl/TableTokenGenerator.java](https://coveralls.io/builds/28902010/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FTableTokenGenerator.java#L123) | 20 | 22 | 90.91%
<!-- | **Total:** | **20** | **22** | **90.91%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28902010/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/28902010) |
| :-- | --: |
| Change from base [Build 909](https://coveralls.io/builds/28901805): | 0.04% |
| Covered Lines: | 10835 |
| Relevant Lines: | 18476 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services