[GitHub] [pinot] walterddr commented on a diff in pull request #9450: [multistage][hotfix] fix filter operator type convert

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9450:
URL: https://github.com/apache/pinot/pull/9450#discussion_r978138877


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/operands/FilterOperand.java:
##########
@@ -150,10 +150,19 @@ public Boolean apply(Object[] row) {
   private static abstract class Predicate extends FilterOperand {
     protected final TransformOperand _lhs;
     protected final TransformOperand _rhs;
+    protected final DataSchema.ColumnDataType _resultType;
 
     public Predicate(List<RexExpression> functionOperands, DataSchema dataSchema) {
       _lhs = TransformOperand.toTransformOperand(functionOperands.get(0), dataSchema);
       _rhs = TransformOperand.toTransformOperand(functionOperands.get(1), dataSchema);
+      if (_lhs._resultType != DataSchema.ColumnDataType.OBJECT) {
+        _resultType = _lhs._resultType;
+      } else if (_rhs._resultType != DataSchema.ColumnDataType.OBJECT){

Review Comment:
   ```suggestion
         } else if (_rhs._resultType != DataSchema.ColumnDataType.OBJECT) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org