You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/24 16:34:53 UTC
[GitHub] [kylin] etherge opened a new pull request #1081: Sonarbugs
etherge opened a new pull request #1081: Sonarbugs
URL: https://github.com/apache/kylin/pull/1081
- Fixed 6 sonar bugs according to the rule: **_Method parameters, caught exceptions and foreach variables' initial values should not be ignored_**
- Fixed 6 sonar bugs according to the rule: **_The value returned from a stream read should be checked_**
- Fixed 5 sonar bugs according to the rule: **_Jump statements should not occur in "finally" blocks_**
- Fixed 4 sonar bugs according to the rule: **_"volatile" variables should not be used with compound operators_**
- Fixed 2 sonar bugs according to the rule: **_"BigDecimal(double)" should not be used_**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1081: Sonarbugs
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1081: Sonarbugs
URL: https://github.com/apache/kylin/pull/1081#issuecomment-578218490
## Pull Request Test Coverage Report for [Build 5556](https://coveralls.io/builds/28312030)
* **46** of **109** **(42.2%)** changed or added relevant lines in **13** files are covered.
* **18** unchanged lines in **6** files lost coverage.
* Overall coverage increased (+**0.003%**) to **27.504%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-metadata/src/main/java/org/apache/kylin/metadata/tuple/Tuple.java](https://coveralls.io/builds/28312030/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ftuple%2FTuple.java#L122) | 0 | 1 | 0.0%
| [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/coprocessor/endpoint/CubeVisitService.java](https://coveralls.io/builds/28312030/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fcube%2Fv2%2Fcoprocessor%2Fendpoint%2FCubeVisitService.java#L433) | 3 | 5 | 60.0%
| [core-common/src/main/java/org/apache/kylin/common/util/DecimalUtil.java](https://coveralls.io/builds/28312030/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FDecimalUtil.java#L35) | 0 | 3 | 0.0%
| [core-dictionary/src/main/java/org/apache/kylin/dict/NumberDictionary.java](https://coveralls.io/builds/28312030/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2FNumberDictionary.java#L49) | 0 | 4 | 0.0%
| [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/ConvSqlWriter.java](https://coveralls.io/builds/28312030/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2Fconv%2FConvSqlWriter.java#L220) | 0 | 4 | 0.0%
| [engine-flink/src/main/java/org/apache/kylin/engine/flink/util/PercentileCounterSerializer.java](https://coveralls.io/builds/28312030/source?filename=engine-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fflink%2Futil%2FPercentileCounterSerializer.java#L54) | 0 | 5 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/gridtable/GTAggregateScanner.java](https://coveralls.io/builds/28312030/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fgridtable%2FGTAggregateScanner.java#L437) | 0 | 8 | 0.0%
| [server-base/src/main/java/org/apache/kylin/rest/controller/StreamingController.java](https://coveralls.io/builds/28312030/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FStreamingController.java#L141) | 0 | 8 | 0.0%
| [server-base/src/main/java/org/apache/kylin/rest/controller/StreamingV2Controller.java](https://coveralls.io/builds/28312030/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FStreamingV2Controller.java#L140) | 0 | 12 | 0.0%
| [stream-core/src/main/java/org/apache/kylin/stream/core/consumer/StreamingConsumerChannel.java](https://coveralls.io/builds/28312030/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fconsumer%2FStreamingConsumerChannel.java#L56) | 0 | 16 | 0.0%
<!-- | **Total:** | **46** | **109** | **42.2%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/NumberDictionary.java](https://coveralls.io/builds/28312030/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2FNumberDictionary.java#L53) | 1 | 30.0% |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/28312030/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
| [server-base/src/main/java/org/apache/kylin/rest/controller/StreamingV2Controller.java](https://coveralls.io/builds/28312030/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FStreamingV2Controller.java#L167) | 2 | 0% |
| [stream-core/src/main/java/org/apache/kylin/stream/core/consumer/StreamingConsumerChannel.java](https://coveralls.io/builds/28312030/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fconsumer%2FStreamingConsumerChannel.java#L113) | 2 | 0% |
| [server-base/src/main/java/org/apache/kylin/rest/controller/StreamingController.java](https://coveralls.io/builds/28312030/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FStreamingController.java#L116) | 4 | 0% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28312030/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L193) | 7 | 76.29% |
<!-- | **Total:** | **18** | | -->
| Totals | [](https://coveralls.io/builds/28312030) |
| :-- | --: |
| Change from base [Build 5555](https://coveralls.io/builds/28301584): | 0.003% |
| Covered Lines: | 24154 |
| Relevant Lines: | 87819 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen merged pull request #1081: Sonar bugs
Posted by GitBox <gi...@apache.org>.
nichunen merged pull request #1081: Sonar bugs
URL: https://github.com/apache/kylin/pull/1081
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services