You are viewing a plain text version of this content. The canonical link for it is here.
Posted to slide-dev@jakarta.apache.org by Martin Kalén <mk...@apache.org> on 2005/05/18 14:39:59 UTC
[ping] Please review patches
Greetings,
I would appreciate if someone with commit karma could review the following:
[1] http://www.mail-archive.com/slide-dev@jakarta.apache.org/msg14543.html
[2] http://www.mail-archive.com/slide-dev@jakarta.apache.org/msg14542.html
[3] http://www.mail-archive.com/slide-dev@jakarta.apache.org/msg14580.html
1. Improves re-usability of Statement for my patch that was already accepted
by Stefan Lützkendorf
2. Just attached a user-supplied suggestion as patch in Bugzilla, fixes broken
permissions-SQL for PostgreSQL (similar to original patch for [1]).
Actual patch is in bugzilla:
http://issues.apache.org/bugzilla/attachment.cgi?id=14636
3. Improves/extends configuration of Commons DBCP. See link to mail archive
for full details.
Thanks!
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: [ping] Please review patches
Posted by Martin Kalén <mk...@apache.org>.
Martin Kalén wrote:
> Greetings,
> I would appreciate if someone with commit karma could review the
> following:
>
> [1] http://www.mail-archive.com/slide-dev@jakarta.apache.org/msg14543.html
Please hold off with this one, since unico just applied another patch on
the affected file.
I will send a new diff against latest HEAD.
Cheers,
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: [ping] Please review patches
Posted by Martin Kalén <mk...@apache.org>.
Unico Hommes wrote:
>>>http://www.mail-archive.com/slide-dev@jakarta.apache.org/msg14580.html
>>>
>>>3. Improves/extends configuration of Commons DBCP.
>>
>>Any feedback on this? Would you like me to create a bugzilla issue?
>
> Yes please. :)
Done:
http://issues.apache.org/bugzilla/show_bug.cgi?id=35235
I got away with my first Slide patch by just mailing the dev-list,
since Stefan Lützkendorf was nice enough to commit it without
a bugzilla issue. :) But I know it's easier to keep track
of everything by strictly using bugzilla for all issues,
so I will stick to this in the future.
Thanks for your efforts, guys!
Regards,
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: [ping] Please review patches
Posted by Unico Hommes <un...@apache.org>.
Martin Kalén wrote:
> Martin Kalén wrote:
>
<snip/>
>> [3]
>> http://www.mail-archive.com/slide-dev@jakarta.apache.org/msg14580.html
>>
>> 3. Improves/extends configuration of Commons DBCP. See link to mail
>> archive
>> for full details.
>
>
> Any feedback on this? Would you like me to create a bugzilla issue?
Yes please. :)
--
Unico
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: [ping] Please review patches
Posted by Martin Kalén <mk...@apache.org>.
Martin Kalén wrote:
> Greetings,
> I would appreciate if someone with commit karma could review the
> following:
>
> [1] http://www.mail-archive.com/slide-dev@jakarta.apache.org/msg14543.html
Applied by Unico. Thanks!
> [2] http://www.mail-archive.com/slide-dev@jakarta.apache.org/msg14542.html
Also applied by Unico (thanks again!) :). However, I had time to regtest with
PostgreSQL today and found out that the user-submitted SQL was not correct
for the case when revisionNumber==null. Since I mainly use Oracle9i, I
previously figured that Oracle and PostgreSQL would behave differently
wrt setNull for statement parameters.
However I verified today that PostgreSQL is behaving like Oracle and since
the CommonRDBMSAdapter has already been fixed for this case, I attached
a new patch for PostgreSQL that will unify the revokePermission code
to look the same in both adapters
http://www.mail-archive.com/slide-dev@jakarta.apache.org/msg14710.html
> [3] http://www.mail-archive.com/slide-dev@jakarta.apache.org/msg14580.html
>
> 3. Improves/extends configuration of Commons DBCP. See link to mail archive
> for full details.
Any feedback on this? Would you like me to create a bugzilla issue?
This one is especially important for long-running applications with
some inactivity times (eg overnight inactive webapps in a corporate
environment) where the server drops the DBCP pooled connections.
To remedy this the DBCP configuration mechanism in Slide must be able
to specify a validation query. Above patch fixes this (and permits
any DBCP configurable option to be set from Slide's Domain.xml).
Thanks to all devs for you continous efforts!
Cheers,
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: [ping] Please review patches
Posted by Unico Hommes <un...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Martin Kalén wrote:
> Martin Kalén wrote:
>
>> Attaching an updated version of the patch against CVS rev 1.11
>
>
> Hmm... not so. :(
>
> The attached v3 of the patch is indeed against CVS rev 1.11,
> including the uri.toString() that unesco committed.
LOL! Unesco... :-) I am assuming a typo.
Thanks for your efforts though I already committed it. I guess you
didn't receive my mail yet. Damned Sober worm spammers :(
- --
Unico
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFCi4kncuec8tVNKAwRAj5zAJ9MLaj7I41og62L9+cukoWCwJ+YyACfagN+
vJS1Ch/ShoSHmqQPqNR1+pc=
=4LNa
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: [ping] Please review patches
Posted by Martin Kalén <mk...@apache.org>.
Martin Kalén wrote:
> Attaching an updated version of the patch against CVS rev 1.11
Hmm... not so. :(
The attached v3 of the patch is indeed against CVS rev 1.11,
including the uri.toString() that unesco committed.
Beg your pardon for the repeated confusion.
Regards,
Martin
Re: [ping] Please review patches
Posted by Martin Kalén <mk...@apache.org>.
Martin Kalén wrote:
> Greetings,
> I would appreciate if someone with commit karma could review the
> following:
>
> [1] http://www.mail-archive.com/slide-dev@jakarta.apache.org/msg14543.html
Attaching an updated version of the patch against CVS rev 1.11
This also fixes a case where Oracle is in fact _not_ compatible
with the PostgreSQL-way of doing things (setNull for statement
is not 1:1 with IS NULL in Oracle).
Regards,
Martin
P.S. ASF mailserver lag is extreme due to the Sober worm, so messages might
appear on the list in a bit of a random order...