You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "icexelloss (via GitHub)" <gi...@apache.org> on 2023/03/20 13:33:05 UTC
[GitHub] [arrow] icexelloss commented on a diff in pull request #34627: GH-34626: [C++] Add ordered/segmented aggregation Substrait extension
icexelloss commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1142123997
##########
cpp/proto/substrait/extension_rels.proto:
##########
@@ -58,3 +58,9 @@ message NamedTapRel {
// If empty, field names will be automatically generated.
repeated string columns = 3;
}
+
+message SegmentedAggregateRel {
+ substrait.AggregateRel aggregate = 1;
+
+ repeated substrait.AggregateRel.Grouping segment_groupings = 2;
Review Comment:
I remember from the discussion that we prefer to use field index here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org