You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2019/12/24 22:24:50 UTC
[GitHub] [libcloud] Kami opened a new pull request #1396: [WIP] Also run
unit tests on Windows using Python 3.7
Kami opened a new pull request #1396: [WIP] Also run unit tests on Windows using Python 3.7
URL: https://github.com/apache/libcloud/pull/1396
Just an experiment to see if we can get unit tests to run under Python 3.7 on Windows.
IIRC, at some point in the past, we did have some unit tests running in Windows, but for one reason or another, they were removed.
Now that #1377 has been merged, this has freed up some Travis CI builders which means that even if we add another builder, in theory, overall test run time should still be the same / shouldn't increase (as long as Windows build doesn't take more than ~2 minutes).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami merged pull request #1396: Also run unit tests on
Windows using Python 3.7
Posted by GitBox <gi...@apache.org>.
Kami merged pull request #1396: Also run unit tests on Windows using Python 3.7
URL: https://github.com/apache/libcloud/pull/1396
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io commented on issue #1396: [WIP] Also run unit
tests on Windows using Python 3.7
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1396: [WIP] Also run unit tests on Windows using Python 3.7
URL: https://github.com/apache/libcloud/pull/1396#issuecomment-569139347
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1396?src=pr&el=h1) Report
> Merging [#1396](https://codecov.io/gh/apache/libcloud/pull/1396?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/c69df0f56178cc3a3e7c5550abaaeef4d33b2882?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `84.9%`.
[](https://codecov.io/gh/apache/libcloud/pull/1396?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1396 +/- ##
==========================================
+ Coverage 86.57% 86.58% +<.01%
==========================================
Files 364 364
Lines 76182 76193 +11
Branches 7438 7439 +1
==========================================
+ Hits 65958 65968 +10
- Misses 7397 7400 +3
+ Partials 2827 2825 -2
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1396?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libcloud/utils/py3.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdXRpbHMvcHkzLnB5) | `41.81% <0%> (ø)` | :arrow_up: |
| [libcloud/test/storage/test\_s3.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9zdG9yYWdlL3Rlc3RfczMucHk=) | `91.47% <100%> (ø)` | :arrow_up: |
| [libcloud/test/compute/test\_ec2.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3RfZWMyLnB5) | `97.95% <100%> (ø)` | :arrow_up: |
| [libcloud/test/test\_utils.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC90ZXN0X3V0aWxzLnB5) | `95.31% <100%> (ø)` | :arrow_up: |
| [libcloud/test/compute/test\_deployment.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3RfZGVwbG95bWVudC5weQ==) | `95.51% <100%> (+0.03%)` | :arrow_up: |
| [libcloud/utils/networking.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdXRpbHMvbmV0d29ya2luZy5weQ==) | `96.87% <100%> (+10.38%)` | :arrow_up: |
| [libcloud/test/test\_init.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC90ZXN0X2luaXQucHk=) | `86.84% <100%> (+1.54%)` | :arrow_up: |
| [libcloud/test/storage/test\_local.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9zdG9yYWdlL3Rlc3RfbG9jYWwucHk=) | `90.45% <28.57%> (-2.3%)` | :arrow_down: |
| [libcloud/test/compute/test\_ssh\_client.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3Rfc3NoX2NsaWVudC5weQ==) | `95.1% <66.66%> (-0.36%)` | :arrow_down: |
| [libcloud/compute/ssh.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9zc2gucHk=) | `75% <0%> (+0.41%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1396?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1396?src=pr&el=footer). Last update [c69df0f...83ac336](https://codecov.io/gh/apache/libcloud/pull/1396?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io edited a comment on issue #1396: Also run
unit tests on Windows using Python 3.7
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1396: Also run unit tests on Windows using Python 3.7
URL: https://github.com/apache/libcloud/pull/1396#issuecomment-569139347
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1396?src=pr&el=h1) Report
> Merging [#1396](https://codecov.io/gh/apache/libcloud/pull/1396?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/c69df0f56178cc3a3e7c5550abaaeef4d33b2882?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `84.9%`.
[](https://codecov.io/gh/apache/libcloud/pull/1396?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1396 +/- ##
==========================================
+ Coverage 86.57% 86.58% +<.01%
==========================================
Files 364 364
Lines 76182 76193 +11
Branches 7438 7439 +1
==========================================
+ Hits 65958 65968 +10
- Misses 7397 7400 +3
+ Partials 2827 2825 -2
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1396?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libcloud/utils/py3.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdXRpbHMvcHkzLnB5) | `41.81% <0%> (ø)` | :arrow_up: |
| [libcloud/test/storage/test\_s3.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9zdG9yYWdlL3Rlc3RfczMucHk=) | `91.47% <100%> (ø)` | :arrow_up: |
| [libcloud/test/compute/test\_ec2.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3RfZWMyLnB5) | `97.95% <100%> (ø)` | :arrow_up: |
| [libcloud/test/test\_utils.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC90ZXN0X3V0aWxzLnB5) | `95.31% <100%> (ø)` | :arrow_up: |
| [libcloud/utils/networking.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdXRpbHMvbmV0d29ya2luZy5weQ==) | `96.87% <100%> (+10.38%)` | :arrow_up: |
| [libcloud/test/test\_init.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC90ZXN0X2luaXQucHk=) | `86.84% <100%> (+1.54%)` | :arrow_up: |
| [libcloud/test/compute/test\_deployment.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3RfZGVwbG95bWVudC5weQ==) | `95.51% <100%> (+0.03%)` | :arrow_up: |
| [libcloud/test/storage/test\_local.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9zdG9yYWdlL3Rlc3RfbG9jYWwucHk=) | `90.45% <28.57%> (-2.3%)` | :arrow_down: |
| [libcloud/test/compute/test\_ssh\_client.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3Rfc3NoX2NsaWVudC5weQ==) | `95.1% <66.66%> (-0.36%)` | :arrow_down: |
| [libcloud/compute/ssh.py](https://codecov.io/gh/apache/libcloud/pull/1396/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9zc2gucHk=) | `75% <0%> (+0.41%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1396?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1396?src=pr&el=footer). Last update [c69df0f...558bd86](https://codecov.io/gh/apache/libcloud/pull/1396?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami commented on issue #1396: [WIP] Also run unit tests
on Windows using Python 3.7
Posted by GitBox <gi...@apache.org>.
Kami commented on issue #1396: [WIP] Also run unit tests on Windows using Python 3.7
URL: https://github.com/apache/libcloud/pull/1396#issuecomment-569135235
Alright, unit tests now pass on Windows.
Only downside is that those tests take ~3 min 40 seconds, whereas most other tests / jobs take maximum of ~2-3 minutes.
The reason for that is that Travis Windows build support is not really great (caching is not really implemented, etc.).
I will go ahead and merge it and if slow tests become an issue, we can always mark those windows unit tests as "allow failure" and set "fail fast" Travis option so the whole build won't wait / block on Windows unit tests job.
I still think it's good to have those tests since in the past we had some small Windows related issues (e.g. maximum file name length limit on Windows).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services