[jira] [Commented] (RATIS-444) Improve logging in RaftLogWorker

["Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707872#comment-16707872 ] 

Tsz Wo Nicholas Sze commented on RATIS-444:
-------------------------------------------

Thanks [~ljain] for working on this.
- Please add a ':' after the name.  It will be consistent with other messages.
- Some log/assert messages missing the name.  Please include it.
- The following log is not clear
{code}
        LOG.info("Truncated log file from {} to {}", fileToTruncate, dstFile);
{code}
How about below?
{code}
        LOG.info("{}: Truncated log file {} to length {} and moved it to {}",
            name, fileToTruncate, segments.toTruncate.targetLength, dstFile);
{code}

BTW, if FileUtils.LOG is set to TRACE level, it will print out a message for all the calls, i.e. delete file, move file, etc.  It seems good to set it in Ozone.

> Improve logging in RaftLogWorker
> --------------------------------
>
>                 Key: RATIS-444
>                 URL: https://issues.apache.org/jira/browse/RATIS-444
>             Project: Ratis
>          Issue Type: Bug
>          Components: server
>            Reporter: Lokesh Jain
>            Assignee: Lokesh Jain
>            Priority: Major
>         Attachments: RATIS-444.001.patch
>
>
> The Jira aims to add more logs for start, rolling and truncate of log segments. Currently these operations are not logged.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)