You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2011/10/12 16:56:08 UTC

Re: svn commit: r1182248 - in /subversion/branches/tree-read-api/subversion/libsvn_client: tree.c tree.h

On Oct 12, 2011 4:02 AM, <ju...@apache.org> wrote:
>...
> +++ subversion/branches/tree-read-api/subversion/libsvn_client/tree.c Wed
Oct 12 08:01:39 2011
> @@ -334,7 +334,7 @@ wc_tree_get_dir(svn_client_tree_t *tree,
>           const char *child_abspath = APR_ARRAY_IDX(children, i, const
char *);
>           const char *name = svn_dirent_basename(child_abspath,
scratch_pool);
>
> -          apr_hash_set(*dirents, name, APR_HASH_KEY_STRING, (void *)1);
> +          apr_hash_set(*dirents, name, APR_HASH_KEY_STRING, name);

Looks like 'name' is in the wrong pool.

Re: svn commit: r1182248 - in /subversion/branches/tree-read-api/subversion/libsvn_client: tree.c tree.h

Posted by Julian Foad <ju...@wandisco.com>.
Greg Stein wrote:
> On Oct 12, 2011 4:02 AM, <ju...@apache.org> wrote:
> >...
> >           const char *name = svn_dirent_basename(child_abspath,
> scratch_pool);
> >
> > -          apr_hash_set(*dirents, name, APR_HASH_KEY_STRING, (void
> *)1);
> > +          apr_hash_set(*dirents, name, APR_HASH_KEY_STRING, name);
> 
> Looks like 'name' is in the wrong pool.

Thanks.  r1182566.

- Julian