You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/21 16:14:00 UTC
[jira] [Commented] (NIFI-5543) Connection path is not visualizing
as selected when hidden linepoint element is clicked
[ https://issues.apache.org/jira/browse/NIFI-5543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587664#comment-16587664 ]
ASF GitHub Bot commented on NIFI-5543:
--------------------------------------
GitHub user markobean opened a pull request:
https://github.com/apache/nifi/pull/2957
NIFI-5543: fix connection path is not visualizing as selected when hi…
…dden linepoint element is clicked
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
Fix was verified by installing and manual UI manipulation. Now, when a bend point of a currently unselected connection is clicked, that connection becomes selected/highlighted.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markobean/nifi NIFI-5543
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2957.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2957
----
commit 4b719c6d9019e1aeabfd5205540ede5653d6236c
Author: Mark Bean <ma...@...>
Date: 2018-08-21T15:37:25Z
NIFI-5543: fix connection path is not visualizing as selected when hidden linepoint element is clicked
----
> Connection path is not visualizing as selected when hidden linepoint element is clicked
> ---------------------------------------------------------------------------------------
>
> Key: NIFI-5543
> URL: https://issues.apache.org/jira/browse/NIFI-5543
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core UI
> Affects Versions: 1.7.1
> Reporter: Mark Bean
> Assignee: Mark Bean
> Priority: Major
>
> Select a connection. Then, select another connection on its bend point. The UI still indicates the original connection is selected. However, it is actually the second connection that is selected - or at least the second connection can be modified even though it is not visually highlighted. This can lead to misinformation on multiple, overlapping connections with the same endpoint.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)