You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2016/05/30 11:54:12 UTC

[jira] [Commented] (OAK-4410) More aggressive cleanup for offline compaction

    [ https://issues.apache.org/jira/browse/OAK-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306566#comment-15306566 ] 

Michael Dürig commented on OAK-4410:
------------------------------------

Patch look good. Just one minor thing: please adapt the comment "the space savings are not worth it at less than 25%..." accordingly to your changes. 

> More aggressive cleanup for offline compaction
> ----------------------------------------------
>
>                 Key: OAK-4410
>                 URL: https://issues.apache.org/jira/browse/OAK-4410
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segmentmk
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>              Labels: candidate_oak_1_2, candidate_oak_1_4, cleanup, gc
>         Attachments: OAK-4410.patch
>
>
> In the case where a segment store doesn't use an external datastore, running offline compaction can result in a slight increase of the overall size, due to the cleanup threshold check present in the TarReader.
> I think we need to be more aggressive with GC for offline compaction (basically reduce the threshold to zero), this would give more predictable results in terms of size.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)