You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/05/24 04:02:48 UTC

[kudu-CR] catalog_manager: move VLOG(1) messages above Async RPC calls to avoid crash

Hello Jean-Daniel Cryans,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3181

to review the following change.

Change subject: catalog_manager: move VLOG(1) messages above Async RPC calls to avoid crash
......................................................................

catalog_manager: move VLOG(1) messages above Async RPC calls to avoid crash

Several functions in this file used a pattern of sending an Async RPC, followed
by logging that the RPC had been sent. However, the callback for the async RPC
could delete the 'this' instance, which would cause the log message to crash.

This only showed up as flakiness in Java unit tests, because they set --v=1
and these messages were VLOG(1).

Change-Id: Ic6beaf940fe42a0c7a3aa5877b7ef65136af210b
---
M src/kudu/master/catalog_manager.cc
1 file changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/3181/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6beaf940fe42a0c7a3aa5877b7ef65136af210b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans