You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Ted Yu <yu...@gmail.com> on 2013/12/03 01:34:14 UTC
Extensions for patches accepted by QA bot
During review of
HBASE-10044 test-patch.sh should filter out documents by known file
extensions
Jesse made the suggestion that QA bot only accepts files with extensions .patch
and .txt
I want to get opinion from the community on this matter.
Thanks
Re: Extensions for patches accepted by QA bot
Posted by Ted Yu <yu...@gmail.com>.
I attached patch v2 to HBASE-10044 which would make QA bot accept the 3
extensions discussed here.
Sorry for the delay - was at a conference last week.
On Thu, Dec 5, 2013 at 9:10 AM, Nick Dimiduk <nd...@gmail.com> wrote:
> Thanks Ted!
>
>
> On Thu, Dec 5, 2013 at 8:50 AM, Ted Yu <yu...@gmail.com> wrote:
>
> > Alright.
> > Plan to stick with previous consensus of 3 file extensions.
> >
> > Cheers
> >
> >
> > On Wed, Dec 4, 2013 at 9:07 AM, Nick Dimiduk <nd...@gmail.com> wrote:
> >
> > > I don't think that's a necessary filter; it'll still get
> false-positives
> > > like HBASE-1234_design_v1.txt. I'd prefer the automation to be kind and
> > > understanding in accepting and evaluating community contributions :)
> > > Running failing to apply a non-patch doesn't really hurt anything.
> > >
> > >
> > > On Tue, Dec 3, 2013 at 9:51 AM, Ted Yu <yu...@gmail.com> wrote:
> > >
> > > > Over in HBASE-10017, the following attachment triggered a QA warning:
> > > >
> > > >
> > >
> >
> http://issues.apache.org/jira/secure/attachment/12616816/patchSiteOutput.txt
> > > >
> > > > Should the acceptance criteria include the notion that there should
> be
> > > JIRA
> > > > number in the filename ?
> > > >
> > > > Thanks
> > > >
> > > >
> > > > On Tue, Dec 3, 2013 at 12:39 AM, Anoop John <an...@gmail.com>
> > > wrote:
> > > >
> > > > > +1 for .patch, .txt, .diff
> > > > >
> > > > > -Anoop-
> > > > >
> > > > > On Tue, Dec 3, 2013 at 6:16 AM, Nick Dimiduk <nd...@gmail.com>
> > > wrote:
> > > > >
> > > > > > Sounds reasonable to me. Maybe add .diff to that list?
> > > > > >
> > > > > >
> > > > > > On Mon, Dec 2, 2013 at 4:34 PM, Ted Yu <yu...@gmail.com>
> > wrote:
> > > > > >
> > > > > > > During review of
> > > > > > > HBASE-10044 test-patch.sh should filter out documents by
> known
> > > file
> > > > > > > extensions
> > > > > > > Jesse made the suggestion that QA bot only accepts files with
> > > > > extensions
> > > > > > > .patch
> > > > > > > and .txt
> > > > > > >
> > > > > > > I want to get opinion from the community on this matter.
> > > > > > >
> > > > > > > Thanks
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Extensions for patches accepted by QA bot
Posted by Nick Dimiduk <nd...@gmail.com>.
Thanks Ted!
On Thu, Dec 5, 2013 at 8:50 AM, Ted Yu <yu...@gmail.com> wrote:
> Alright.
> Plan to stick with previous consensus of 3 file extensions.
>
> Cheers
>
>
> On Wed, Dec 4, 2013 at 9:07 AM, Nick Dimiduk <nd...@gmail.com> wrote:
>
> > I don't think that's a necessary filter; it'll still get false-positives
> > like HBASE-1234_design_v1.txt. I'd prefer the automation to be kind and
> > understanding in accepting and evaluating community contributions :)
> > Running failing to apply a non-patch doesn't really hurt anything.
> >
> >
> > On Tue, Dec 3, 2013 at 9:51 AM, Ted Yu <yu...@gmail.com> wrote:
> >
> > > Over in HBASE-10017, the following attachment triggered a QA warning:
> > >
> > >
> >
> http://issues.apache.org/jira/secure/attachment/12616816/patchSiteOutput.txt
> > >
> > > Should the acceptance criteria include the notion that there should be
> > JIRA
> > > number in the filename ?
> > >
> > > Thanks
> > >
> > >
> > > On Tue, Dec 3, 2013 at 12:39 AM, Anoop John <an...@gmail.com>
> > wrote:
> > >
> > > > +1 for .patch, .txt, .diff
> > > >
> > > > -Anoop-
> > > >
> > > > On Tue, Dec 3, 2013 at 6:16 AM, Nick Dimiduk <nd...@gmail.com>
> > wrote:
> > > >
> > > > > Sounds reasonable to me. Maybe add .diff to that list?
> > > > >
> > > > >
> > > > > On Mon, Dec 2, 2013 at 4:34 PM, Ted Yu <yu...@gmail.com>
> wrote:
> > > > >
> > > > > > During review of
> > > > > > HBASE-10044 test-patch.sh should filter out documents by known
> > file
> > > > > > extensions
> > > > > > Jesse made the suggestion that QA bot only accepts files with
> > > > extensions
> > > > > > .patch
> > > > > > and .txt
> > > > > >
> > > > > > I want to get opinion from the community on this matter.
> > > > > >
> > > > > > Thanks
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Extensions for patches accepted by QA bot
Posted by Ted Yu <yu...@gmail.com>.
Alright.
Plan to stick with previous consensus of 3 file extensions.
Cheers
On Wed, Dec 4, 2013 at 9:07 AM, Nick Dimiduk <nd...@gmail.com> wrote:
> I don't think that's a necessary filter; it'll still get false-positives
> like HBASE-1234_design_v1.txt. I'd prefer the automation to be kind and
> understanding in accepting and evaluating community contributions :)
> Running failing to apply a non-patch doesn't really hurt anything.
>
>
> On Tue, Dec 3, 2013 at 9:51 AM, Ted Yu <yu...@gmail.com> wrote:
>
> > Over in HBASE-10017, the following attachment triggered a QA warning:
> >
> >
> http://issues.apache.org/jira/secure/attachment/12616816/patchSiteOutput.txt
> >
> > Should the acceptance criteria include the notion that there should be
> JIRA
> > number in the filename ?
> >
> > Thanks
> >
> >
> > On Tue, Dec 3, 2013 at 12:39 AM, Anoop John <an...@gmail.com>
> wrote:
> >
> > > +1 for .patch, .txt, .diff
> > >
> > > -Anoop-
> > >
> > > On Tue, Dec 3, 2013 at 6:16 AM, Nick Dimiduk <nd...@gmail.com>
> wrote:
> > >
> > > > Sounds reasonable to me. Maybe add .diff to that list?
> > > >
> > > >
> > > > On Mon, Dec 2, 2013 at 4:34 PM, Ted Yu <yu...@gmail.com> wrote:
> > > >
> > > > > During review of
> > > > > HBASE-10044 test-patch.sh should filter out documents by known
> file
> > > > > extensions
> > > > > Jesse made the suggestion that QA bot only accepts files with
> > > extensions
> > > > > .patch
> > > > > and .txt
> > > > >
> > > > > I want to get opinion from the community on this matter.
> > > > >
> > > > > Thanks
> > > > >
> > > >
> > >
> >
>
Re: Extensions for patches accepted by QA bot
Posted by Jonathan Hsieh <jo...@cloudera.com>.
I like the idea of being able to target patches at a branch. +1 if someone
does it. :)
On Tue, Dec 3, 2013 at 5:10 PM, Sergey Shelukhin <se...@hortonworks.com>wrote:
> Hive QA has a more strict filter, which can also be used to test patches
> against specific branch: "Upload a patch to a JIRA in the following format
> HIVE-XXXX.patch, HIVE-XXXX.XX.patch, HIVE-XXXX.DXXXX.XX.patch
> (phabricator), or HIVE-XXXX-branch.patch (allows targeting a branch)."
>
> https://cwiki.apache.org/confluence/display/Hive/Hive+PreCommit+Patch+Testing
>
> I think it is a good idea... people attach all kinds of stuff to jira
>
>
> On Tue, Dec 3, 2013 at 5:07 PM, Nick Dimiduk <nd...@gmail.com> wrote:
>
> > I don't think that's a necessary filter; it'll still get false-positives
> > like HBASE-1234_design_v1.txt. I'd prefer the automation to be kind and
> > understanding in accepting and evaluating community contributions :)
> > Running failing to apply a non-patch doesn't really hurt anything.
> >
> >
> > On Tue, Dec 3, 2013 at 9:51 AM, Ted Yu <yu...@gmail.com> wrote:
> >
> > > Over in HBASE-10017, the following attachment triggered a QA warning:
> > >
> > >
> >
> http://issues.apache.org/jira/secure/attachment/12616816/patchSiteOutput.txt
> > >
> > > Should the acceptance criteria include the notion that there should be
> > JIRA
> > > number in the filename ?
> > >
> > > Thanks
> > >
> > >
> > > On Tue, Dec 3, 2013 at 12:39 AM, Anoop John <an...@gmail.com>
> > wrote:
> > >
> > > > +1 for .patch, .txt, .diff
> > > >
> > > > -Anoop-
> > > >
> > > > On Tue, Dec 3, 2013 at 6:16 AM, Nick Dimiduk <nd...@gmail.com>
> > wrote:
> > > >
> > > > > Sounds reasonable to me. Maybe add .diff to that list?
> > > > >
> > > > >
> > > > > On Mon, Dec 2, 2013 at 4:34 PM, Ted Yu <yu...@gmail.com>
> wrote:
> > > > >
> > > > > > During review of
> > > > > > HBASE-10044 test-patch.sh should filter out documents by known
> > file
> > > > > > extensions
> > > > > > Jesse made the suggestion that QA bot only accepts files with
> > > > extensions
> > > > > > .patch
> > > > > > and .txt
> > > > > >
> > > > > > I want to get opinion from the community on this matter.
> > > > > >
> > > > > > Thanks
> > > > > >
> > > > >
> > > >
> > >
> >
>
> --
> CONFIDENTIALITY NOTICE
> NOTICE: This message is intended for the use of the individual or entity to
> which it is addressed and may contain information that is confidential,
> privileged and exempt from disclosure under applicable law. If the reader
> of this message is not the intended recipient, you are hereby notified that
> any printing, copying, dissemination, distribution, disclosure or
> forwarding of this communication is strictly prohibited. If you have
> received this communication in error, please contact the sender immediately
> and delete it from your system. Thank You.
>
--
// Jonathan Hsieh (shay)
// Software Engineer, Cloudera
// jon@cloudera.com
Re: Extensions for patches accepted by QA bot
Posted by Sergey Shelukhin <se...@hortonworks.com>.
Hive QA has a more strict filter, which can also be used to test patches
against specific branch: "Upload a patch to a JIRA in the following format
HIVE-XXXX.patch, HIVE-XXXX.XX.patch, HIVE-XXXX.DXXXX.XX.patch
(phabricator), or HIVE-XXXX-branch.patch (allows targeting a branch)."
https://cwiki.apache.org/confluence/display/Hive/Hive+PreCommit+Patch+Testing
I think it is a good idea... people attach all kinds of stuff to jira
On Tue, Dec 3, 2013 at 5:07 PM, Nick Dimiduk <nd...@gmail.com> wrote:
> I don't think that's a necessary filter; it'll still get false-positives
> like HBASE-1234_design_v1.txt. I'd prefer the automation to be kind and
> understanding in accepting and evaluating community contributions :)
> Running failing to apply a non-patch doesn't really hurt anything.
>
>
> On Tue, Dec 3, 2013 at 9:51 AM, Ted Yu <yu...@gmail.com> wrote:
>
> > Over in HBASE-10017, the following attachment triggered a QA warning:
> >
> >
> http://issues.apache.org/jira/secure/attachment/12616816/patchSiteOutput.txt
> >
> > Should the acceptance criteria include the notion that there should be
> JIRA
> > number in the filename ?
> >
> > Thanks
> >
> >
> > On Tue, Dec 3, 2013 at 12:39 AM, Anoop John <an...@gmail.com>
> wrote:
> >
> > > +1 for .patch, .txt, .diff
> > >
> > > -Anoop-
> > >
> > > On Tue, Dec 3, 2013 at 6:16 AM, Nick Dimiduk <nd...@gmail.com>
> wrote:
> > >
> > > > Sounds reasonable to me. Maybe add .diff to that list?
> > > >
> > > >
> > > > On Mon, Dec 2, 2013 at 4:34 PM, Ted Yu <yu...@gmail.com> wrote:
> > > >
> > > > > During review of
> > > > > HBASE-10044 test-patch.sh should filter out documents by known
> file
> > > > > extensions
> > > > > Jesse made the suggestion that QA bot only accepts files with
> > > extensions
> > > > > .patch
> > > > > and .txt
> > > > >
> > > > > I want to get opinion from the community on this matter.
> > > > >
> > > > > Thanks
> > > > >
> > > >
> > >
> >
>
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to
which it is addressed and may contain information that is confidential,
privileged and exempt from disclosure under applicable law. If the reader
of this message is not the intended recipient, you are hereby notified that
any printing, copying, dissemination, distribution, disclosure or
forwarding of this communication is strictly prohibited. If you have
received this communication in error, please contact the sender immediately
and delete it from your system. Thank You.
Re: Extensions for patches accepted by QA bot
Posted by Nick Dimiduk <nd...@gmail.com>.
I don't think that's a necessary filter; it'll still get false-positives
like HBASE-1234_design_v1.txt. I'd prefer the automation to be kind and
understanding in accepting and evaluating community contributions :)
Running failing to apply a non-patch doesn't really hurt anything.
On Tue, Dec 3, 2013 at 9:51 AM, Ted Yu <yu...@gmail.com> wrote:
> Over in HBASE-10017, the following attachment triggered a QA warning:
>
> http://issues.apache.org/jira/secure/attachment/12616816/patchSiteOutput.txt
>
> Should the acceptance criteria include the notion that there should be JIRA
> number in the filename ?
>
> Thanks
>
>
> On Tue, Dec 3, 2013 at 12:39 AM, Anoop John <an...@gmail.com> wrote:
>
> > +1 for .patch, .txt, .diff
> >
> > -Anoop-
> >
> > On Tue, Dec 3, 2013 at 6:16 AM, Nick Dimiduk <nd...@gmail.com> wrote:
> >
> > > Sounds reasonable to me. Maybe add .diff to that list?
> > >
> > >
> > > On Mon, Dec 2, 2013 at 4:34 PM, Ted Yu <yu...@gmail.com> wrote:
> > >
> > > > During review of
> > > > HBASE-10044 test-patch.sh should filter out documents by known file
> > > > extensions
> > > > Jesse made the suggestion that QA bot only accepts files with
> > extensions
> > > > .patch
> > > > and .txt
> > > >
> > > > I want to get opinion from the community on this matter.
> > > >
> > > > Thanks
> > > >
> > >
> >
>
Re: Extensions for patches accepted by QA bot
Posted by Ted Yu <yu...@gmail.com>.
Over in HBASE-10017, the following attachment triggered a QA warning:
http://issues.apache.org/jira/secure/attachment/12616816/patchSiteOutput.txt
Should the acceptance criteria include the notion that there should be JIRA
number in the filename ?
Thanks
On Tue, Dec 3, 2013 at 12:39 AM, Anoop John <an...@gmail.com> wrote:
> +1 for .patch, .txt, .diff
>
> -Anoop-
>
> On Tue, Dec 3, 2013 at 6:16 AM, Nick Dimiduk <nd...@gmail.com> wrote:
>
> > Sounds reasonable to me. Maybe add .diff to that list?
> >
> >
> > On Mon, Dec 2, 2013 at 4:34 PM, Ted Yu <yu...@gmail.com> wrote:
> >
> > > During review of
> > > HBASE-10044 test-patch.sh should filter out documents by known file
> > > extensions
> > > Jesse made the suggestion that QA bot only accepts files with
> extensions
> > > .patch
> > > and .txt
> > >
> > > I want to get opinion from the community on this matter.
> > >
> > > Thanks
> > >
> >
>
Re: Extensions for patches accepted by QA bot
Posted by Anoop John <an...@gmail.com>.
+1 for .patch, .txt, .diff
-Anoop-
On Tue, Dec 3, 2013 at 6:16 AM, Nick Dimiduk <nd...@gmail.com> wrote:
> Sounds reasonable to me. Maybe add .diff to that list?
>
>
> On Mon, Dec 2, 2013 at 4:34 PM, Ted Yu <yu...@gmail.com> wrote:
>
> > During review of
> > HBASE-10044 test-patch.sh should filter out documents by known file
> > extensions
> > Jesse made the suggestion that QA bot only accepts files with extensions
> > .patch
> > and .txt
> >
> > I want to get opinion from the community on this matter.
> >
> > Thanks
> >
>
Re: Extensions for patches accepted by QA bot
Posted by Nick Dimiduk <nd...@gmail.com>.
Sounds reasonable to me. Maybe add .diff to that list?
On Mon, Dec 2, 2013 at 4:34 PM, Ted Yu <yu...@gmail.com> wrote:
> During review of
> HBASE-10044 test-patch.sh should filter out documents by known file
> extensions
> Jesse made the suggestion that QA bot only accepts files with extensions
> .patch
> and .txt
>
> I want to get opinion from the community on this matter.
>
> Thanks
>