You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/07/17 18:31:20 UTC

[GitHub] [kafka] mjsax commented on a change in pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

mjsax commented on a change in pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#discussion_r456608124



##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java
##########
@@ -265,7 +265,7 @@ public void shouldNotAllowToResetWhenIntermediateTopicAbsent() throws Exception
     public void testResetWhenLongSessionTimeoutConfiguredWithForceOption() throws Exception {

Review comment:
       Well, actually, we don't want to run all test 2x. The Ssl test only executes 3 test (on purpose) as the other tests would be repetitive and don't add value. -- Given that we alway try to keep test execution time short, we can save about 1 minute if we avoid running the tests twice? Thoughts? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org