[GitHub] yuxihu commented on a change in pull request #13452: Get the correct include path in pip package

[GitBox <gi...@apache.org>]

yuxihu commented on a change in pull request #13452: Get the correct include path in pip package
URL: https://github.com/apache/incubator-mxnet/pull/13452#discussion_r237607803
 
 

 ##########
 File path: python/mxnet/libinfo.py
 ##########
 @@ -97,9 +97,16 @@ def find_include_path():
 
     curr_path = os.path.dirname(os.path.abspath(os.path.expanduser(__file__)))
     incl_path = os.path.join(curr_path, '../../include/')
 
 Review comment:
   I think we should check pip path first. Most of the cases we should be able to find it there. And it might be the preferred path, as in Carl's horovod instruction, the include files are also copied under python/mxnet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services