[GitHub] [pulsar] jerrypeng commented on a change in pull request #7890: convertFromConfig should support an overloading of cluster Name

[GitBox <gi...@apache.org>]

jerrypeng commented on a change in pull request #7890:
URL: https://github.com/apache/pulsar/pull/7890#discussion_r476230978



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/common/configuration/PulsarConfigurationLoader.java
##########
@@ -173,7 +173,8 @@ private static boolean isEmpty(Object obj) {
      *             if conf has the field whose name is not contained in ServiceConfiguration and ignoreNonExistMember is false.
      * @throws RuntimeException
      */
-    public static ServiceConfiguration convertFrom(PulsarConfiguration conf, boolean ignoreNonExistMember) throws RuntimeException {
+    public static ServiceConfiguration convertFrom(PulsarConfiguration conf, boolean ignoreNonExistMember,

Review comment:
       I would recommend not modifying these methods for the use case in the worker.  It doesn't really make sense to modify the method to allow override of one specific config. We should just do the override in the worker code itself.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org