You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Benjamin Francisoud (JIRA)" <ji...@apache.org> on 2008/01/22 14:48:34 UTC
[jira] Created: (PIG-68) Improving build.xml in many ways :)
Improving build.xml in many ways :)
-----------------------------------
Key: PIG-68
URL: https://issues.apache.org/jira/browse/PIG-68
Project: Pig
Issue Type: Improvement
Affects Versions: 0.1.0
Reporter: Benjamin Francisoud
Priority: Minor
The build file can be improve in many ways:
* add revision number to pig.jar name (like: pig-r1234.jar)
* put pig.jar in the dist dir
* "clean" target leave a "depend" folder undeleted
* use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
* put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
* provide a description for targets (for "ant -projecthelp" command)
* use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-68) Improving build.xml in many ways :)
Posted by "Benjamin Francisoud (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Francisoud updated PIG-68:
-----------------------------------
Attachment: build.xml-PIG-68-v04.patch
My mistake, I didn't use the correct syntax in the delete tag.
In this patch version I replaced it with:
{code:xml}
<delete>
<fileset dir="${src.dir}/org/apache/pig/impl/logicalLayer/parser" includes="*.java"/>
<fileset dir="${src.dir}/org/apache/pig/tools/pigscript/parser" includes="*.java"/>
</delete>
{code}
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-68) Improving build.xml in many ways :)
Posted by "Utkarsh Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565916#action_12565916 ]
Utkarsh Srivastava commented on PIG-68:
---------------------------------------
+1
Olga, or Alan, I think a review from one of you two is needed before I can commit this one.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-68) Improving build.xml in many ways :)
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566395#action_12566395 ]
Olga Natkovich commented on PIG-68:
-----------------------------------
I applied the patch to my tree and ran "ant clean" and it did not remove java files generated by javacc. I see that you have a pattern in clean that should remove them but it did not work in my case. Does it work for you?
I am using the following version of ant: Apache Ant version 1.6.5 compiled on June 2 2005.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-68) Improving build.xml in many ways :)
Posted by "Benjamin Francisoud (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Francisoud updated PIG-68:
-----------------------------------
Attachment: build.xml-PIG-68-v02.patch
previous patch was wrong, I forgot to add this line:
<delete file="${src.dir}/org/apache/pig/tools/pigscript/parser/*.java" />
adding new patch.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-68) Improving build.xml in many ways :)
Posted by "Stefan Groschupf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Groschupf updated PIG-68:
--------------------------------
Attachment: build.xml-PIG-68-v07-SG.patch
regenerated against latest svn.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch, build.xml-PIG-68-v07-SG.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-68) Improving build.xml in many ways :)
Posted by "Benjamin Francisoud (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Francisoud updated PIG-68:
-----------------------------------
Attachment: build.xml-PIG-68-v05.patch
Fixed the "clean" target (but don't delete PigScriptParser.jj; can be added later)
Fixed the test target added some test output in the console using this line:
{code:xml}
<formatter type="plain" usefile="no"/>
{code}
Unfortunately some tests don't pass on my local cluster but I don't think it's related to ant.
The same tests are also failing the same way with a non modify build.xml.
Can you try the patch by running the tests.
Thanks
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-68) Improving build.xml in many ways :)
Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562756#action_12562756 ]
Andrzej Bialecki commented on PIG-68:
--------------------------------------
Not all supported OS-es support symlinks - Windows doesn't.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-68) Improving build.xml in many ways :)
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566729#action_12566729 ]
Olga Natkovich commented on PIG-68:
-----------------------------------
NodeGenerator is needed - without it the code does not compile. Also, clean build does not compile. I think you need to also remove QueryParser.jj file in thesrc/org/apache/pig/tools/pigscript/parser/ directory since it is generated.
Please, make sure that ant clean followed by ant builds successfully with your next change and also that unit tests run, thanks.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-68) Improving build.xml in many ways :)
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571645#action_12571645 ]
Olga Natkovich commented on PIG-68:
-----------------------------------
When I got a brand new tree, the compile went fine but all unit tests failed. Are you able to run unit tests?
I guess I will try with new unit tests that just got checked in and see what happens
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch, build.xml-PIG-68-v07-SG.patch, out
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-68) Improving build.xml in many ways :)
Posted by "Stefan Groschupf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Groschupf updated PIG-68:
--------------------------------
Attachment: build.xml
Here again the plain build.xml you might just overwrite the existing. Should be no problem with svn.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch, build.xml-PIG-68-v07-SG.patch, build.xml-PIG-68-v08-SG.patch, build.xml-PIG-68-v09-SG.patch, out
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-68) Improving build.xml in many ways :)
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572173#action_12572173 ]
Olga Natkovich commented on PIG-68:
-----------------------------------
+1
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch, build.xml-PIG-68-v07-SG.patch, build.xml-PIG-68-v08-SG.patch, build.xml-PIG-68-v09-SG.patch, out
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-68) Improving build.xml in many ways :)
Posted by "Stefan Groschupf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Groschupf updated PIG-68:
--------------------------------
Attachment: build.xml-PIG-68-v06-SG.patch
Here is my contribution to this topic.
I basically completely rewrote the build.xml in a clean way based on the hadoop build.xml.
The build.xml provides all functionality as before, plus
+ creating a pig and a pig-core.jar (as contributed by Iván de Prado).
+ creating a release tar ball - as hadoop
+ generate all sources into a separated folder for easy generation and removal.
+ improved configuration using build.properties
+ improved naming of jar files (version name)
+ improved java doc rendering
+ improved manifest file
+ improved formating
My patch does not use the svn revision number as Benjamin Francisoud verison does.
In general I like the idea very much but from my pov should a revision number only in "dev" jar name.
I guess it is possible to attach the revision number in case the version name end on "-dev" but I had trouble to use ant conditions and string comparison. Maybe a ant pro can help with this last little improvement.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-68) Improving build.xml in many ways :)
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571562#action_12571562 ]
Olga Natkovich commented on PIG-68:
-----------------------------------
I can't get the code to compile with the latest patch. Will attach the output
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch, build.xml-PIG-68-v07-SG.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-68) Improving build.xml in many ways :)
Posted by "Stefan Groschupf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571643#action_12571643 ]
Stefan Groschupf commented on PIG-68:
-------------------------------------
I just tried the build file again. I get a set of wanring, however all classes compile.
The 18 duplicate class error you get means you have a collision in the name space. Means somehow some classes exists twice in your classpath. My guess is you have the generated classes still in your project.
Please make sure you do a ant clean before you patch the build file or please delete the javacc generated files manually.
Also after patching you need to add src-gen to the classpath of your IDE in case you use one.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch, build.xml-PIG-68-v07-SG.patch, out
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-68) Improving build.xml in many ways :)
Posted by "Benjamin Francisoud (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Francisoud updated PIG-68:
-----------------------------------
Attachment: build.xml-PIG-68-v03.patch
When I did this patch, I didn't notice that pig.jar was use in script or documentation.
The fact that this patch set it's name to pig-r1234.jar is convenient on a developer /release manager point of view but less when it comes to scripts and documentation like in [deploying pig page|http://incubator.apache.org/pig/deployment.html]
In this patch version, I added a <copy ...> at the end of the jar target to make a copy of dist/pig-r1234.jar to pig.jar
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-68) Improving build.xml in many ways :)
Posted by "Xu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571650#action_12571650 ]
Xu Zhang commented on PIG-68:
-----------------------------
FYI, with the new unit test framework, you just need to issue "ant test" to run it on a local cluster.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch, build.xml-PIG-68-v07-SG.patch, out
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-68) Improving build.xml in many ways :)
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571648#action_12571648 ]
Olga Natkovich commented on PIG-68:
-----------------------------------
Stephan, sorry, can you make one more patch agains the latest tree. Your changes conflict with the unit test changes and I am not quite sure how to resolve them, thanks
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch, build.xml-PIG-68-v07-SG.patch, out
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-68) Improving build.xml in many ways :)
Posted by "Benjamin Francisoud (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566537#action_12566537 ]
Benjamin Francisoud commented on PIG-68:
----------------------------------------
I think the package name changed because of PIG-32 so I suppose the regexp to delete those files need to be updated.
I will take a look at it.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-68) Improving build.xml in many ways :)
Posted by "Benjamin Francisoud (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567036#action_12567036 ]
Benjamin Francisoud commented on PIG-68:
----------------------------------------
Same with PigScriptParser.jj ? Should it be deleted ?
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-68) Improving build.xml in many ways :)
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-68:
------------------------------
Attachment: out
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch, build.xml-PIG-68-v07-SG.patch, out
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-68) Improving build.xml in many ways :)
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571253#action_12571253 ]
Olga Natkovich commented on PIG-68:
-----------------------------------
I tried to integrate the latest patch into my tree but it failed.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-68) Improving build.xml in many ways :)
Posted by "Stefan Groschupf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571656#action_12571656 ]
Stefan Groschupf commented on PIG-68:
-------------------------------------
I will fix it, give me some minutes.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch, build.xml-PIG-68-v07-SG.patch, out
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-68) Improving build.xml in many ways :)
Posted by "Stefan Groschupf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Groschupf updated PIG-68:
--------------------------------
Attachment: (was: build.xml)
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch, build.xml-PIG-68-v07-SG.patch, build.xml-PIG-68-v08-SG.patch, build.xml-PIG-68-v09-SG.patch, out
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-68) Improving build.xml in many ways :)
Posted by "Utkarsh Srivastava (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562597#action_12562597 ]
Utkarsh Srivastava commented on PIG-68:
---------------------------------------
Looks great.
Wouldn't it be better to leave a symlink in ${basedir} called pig.jar so that it is easy to run. Plus existing scripts that assume that existence don't break. That would also need to be deleted on clean.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-68) Improving build.xml in many ways :)
Posted by "Benjamin Francisoud (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566548#action_12566548 ]
Benjamin Francisoud commented on PIG-68:
----------------------------------------
Does [NodeIdGenerator.java|http://svn.apache.org/repos/asf/incubator/pig/trunk/src/org/apache/pig/impl/logicalLayer/parser/NodeIdGenerator.java] should be deleted also, it is commited in svn ?
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-68) Improving build.xml in many ways :)
Posted by "Stefan Groschupf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Groschupf updated PIG-68:
--------------------------------
Attachment: build.xml
... for better readability here the new build.xml as plain file and not as diff.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-68) Improving build.xml in many ways :)
Posted by "Stefan Groschupf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Groschupf updated PIG-68:
--------------------------------
Attachment: build.xml-PIG-68-v08-SG.patch
patch build.xml against r630017.
There was a problem in my last patch related to the test classpath this is fixed now.
The tests itself run now, but some are failing on my laptop, but I think it is not related to the build.xml file.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch, build.xml-PIG-68-v07-SG.patch, build.xml-PIG-68-v08-SG.patch, out
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-68) Improving build.xml in many ways :)
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571677#action_12571677 ]
Olga Natkovich commented on PIG-68:
-----------------------------------
I tried to apply the patch to the latest code but it failed:
patch -p0 </home/olgan/src/pig-apache-trunk/pig/trunk/build.xml-PIG-68-v08-SG.patch
patching file build.xml
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file build.xml.rej
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch, build.xml-PIG-68-v07-SG.patch, build.xml-PIG-68-v08-SG.patch, out
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PIG-68) Improving build.xml in many ways :)
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich resolved PIG-68.
-------------------------------
Resolution: Fixed
Patch comitted. Thanks Benjamin and Stefan for contributing this patch
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch, build.xml-PIG-68-v07-SG.patch, build.xml-PIG-68-v08-SG.patch, build.xml-PIG-68-v09-SG.patch, out
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-68) Improving build.xml in many ways :)
Posted by "Stefan Groschupf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Groschupf updated PIG-68:
--------------------------------
Attachment: build.xml-PIG-68-v09-SG.patch
BUILD SUCCESSFUL
Total time: 12 minutes 35 seconds
:-D
Sorry, it was related to the build.xml. Basically the jarManager failed, since I did run the tests with the compiled classes directly but the jarManager is searching for a physically existing jar file.
Fixed with patch version 9.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch, build.xml-PIG-68-v07-SG.patch, build.xml-PIG-68-v08-SG.patch, build.xml-PIG-68-v09-SG.patch, out
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-68) Improving build.xml in many ways :)
Posted by "Benjamin Francisoud (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Francisoud updated PIG-68:
-----------------------------------
Attachment: build.xml-PIG-68-v01.patch
patch for trunk/build.xml
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.