You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Balázs Donát Bessenyei <be...@cloudera.com> on 2016/08/09 12:10:17 UTC
Re: Review Request 50564: Patch for FLUME-2844 - ChannelCounter of
SpillableMemoryChannel doesn't register actually.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50564/#review145202
-----------------------------------------------------------
flume-ng-channels/flume-spillable-memory-channel/src/test/java/org/apache/flume/channel/TestSpillableMemoryChannel.java (lines 685 - 687)
<https://reviews.apache.org/r/50564/#comment211351>
The (modified) tests seem to be running fine without the change in SpillableMemoryChannel.java.
- Bal�zs Don�t Bessenyei
On July 28, 2016, 12:57 p.m., Denes Arvay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50564/
> -----------------------------------------------------------
>
> (Updated July 28, 2016, 12:57 p.m.)
>
>
> Review request for Flume, Bal�zs Don�t Bessenyei, Mike Percy, and Attila Simon.
>
>
> Bugs: FLUME-2844
> https://issues.apache.org/jira/browse/FLUME-2844
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Patch for FLUME-2844 - ChannelCounter of SpillableMemoryChannel doesn't register actually.
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-spillable-memory-channel/src/main/java/org/apache/flume/channel/SpillableMemoryChannel.java b46d646
> flume-ng-channels/flume-spillable-memory-channel/src/test/java/org/apache/flume/channel/TestSpillableMemoryChannel.java 848636b
>
> Diff: https://reviews.apache.org/r/50564/diff/
>
>
> Testing
> -------
>
> - checkstyle passes
> - `flume-ng-channels` tests pass
>
>
> Thanks,
>
> Denes Arvay
>
>
Re: Review Request 50564: Patch for FLUME-2844 - ChannelCounter of
SpillableMemoryChannel doesn't register actually.
Posted by Denes Arvay <de...@cloudera.com>.
> On Aug. 9, 2016, 12:10 p.m., Bal�zs Don�t Bessenyei wrote:
> > flume-ng-channels/flume-spillable-memory-channel/src/test/java/org/apache/flume/channel/TestSpillableMemoryChannel.java, lines 685-687
> > <https://reviews.apache.org/r/50564/diff/1/?file=1456530#file1456530line685>
> >
> > The (modified) tests seem to be running fine without the change in SpillableMemoryChannel.java.
Are you sure? for me without the change in SpillableMemoryChannel.java:
```
flume/flume-ng-channels/flume-spillable-memory-channel# mvn clean test
[...]
Tests run: 14, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 38.074 sec <<< FAILURE!
testCounters(org.apache.flume.channel.TestSpillableMemoryChannel) Time elapsed: 23 sec <<< FAILURE!
java.lang.AssertionError: channel.channelCounter should have started
[...]
```
with the change it passes.
- Denes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50564/#review145202
-----------------------------------------------------------
On July 28, 2016, 12:57 p.m., Denes Arvay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50564/
> -----------------------------------------------------------
>
> (Updated July 28, 2016, 12:57 p.m.)
>
>
> Review request for Flume, Bal�zs Don�t Bessenyei, Mike Percy, and Attila Simon.
>
>
> Bugs: FLUME-2844
> https://issues.apache.org/jira/browse/FLUME-2844
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Patch for FLUME-2844 - ChannelCounter of SpillableMemoryChannel doesn't register actually.
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-spillable-memory-channel/src/main/java/org/apache/flume/channel/SpillableMemoryChannel.java b46d646
> flume-ng-channels/flume-spillable-memory-channel/src/test/java/org/apache/flume/channel/TestSpillableMemoryChannel.java 848636b
>
> Diff: https://reviews.apache.org/r/50564/diff/
>
>
> Testing
> -------
>
> - checkstyle passes
> - `flume-ng-channels` tests pass
>
>
> Thanks,
>
> Denes Arvay
>
>
Re: Review Request 50564: Patch for FLUME-2844 - ChannelCounter of
SpillableMemoryChannel doesn't register actually.
Posted by Balázs Donát Bessenyei <be...@cloudera.com>.
> On Aug. 9, 2016, 12:10 p.m., Bal�zs Don�t Bessenyei wrote:
> > flume-ng-channels/flume-spillable-memory-channel/src/test/java/org/apache/flume/channel/TestSpillableMemoryChannel.java, lines 685-687
> > <https://reviews.apache.org/r/50564/diff/1/?file=1456530#file1456530line685>
> >
> > The (modified) tests seem to be running fine without the change in SpillableMemoryChannel.java.
>
> Denes Arvay wrote:
> Are you sure? for me without the change in SpillableMemoryChannel.java:
> ```
> flume/flume-ng-channels/flume-spillable-memory-channel# mvn clean test
> [...]
> Tests run: 14, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 38.074 sec <<< FAILURE!
> testCounters(org.apache.flume.channel.TestSpillableMemoryChannel) Time elapsed: 23 sec <<< FAILURE!
> java.lang.AssertionError: channel.channelCounter should have started
> [...]
> ```
> with the change it passes.
You are right, I was mistaken
- Bal�zs Don�t
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50564/#review145202
-----------------------------------------------------------
On July 28, 2016, 12:57 p.m., Denes Arvay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50564/
> -----------------------------------------------------------
>
> (Updated July 28, 2016, 12:57 p.m.)
>
>
> Review request for Flume, Bal�zs Don�t Bessenyei, Mike Percy, and Attila Simon.
>
>
> Bugs: FLUME-2844
> https://issues.apache.org/jira/browse/FLUME-2844
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Patch for FLUME-2844 - ChannelCounter of SpillableMemoryChannel doesn't register actually.
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-spillable-memory-channel/src/main/java/org/apache/flume/channel/SpillableMemoryChannel.java b46d646
> flume-ng-channels/flume-spillable-memory-channel/src/test/java/org/apache/flume/channel/TestSpillableMemoryChannel.java 848636b
>
> Diff: https://reviews.apache.org/r/50564/diff/
>
>
> Testing
> -------
>
> - checkstyle passes
> - `flume-ng-channels` tests pass
>
>
> Thanks,
>
> Denes Arvay
>
>