[GitHub] spark pull request: [SPARK-2960][Deploy] Support executing Spark f...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8669#discussion_r43784748
  
    --- Diff: sbin/start-slaves.sh ---
    @@ -52,11 +51,11 @@ if [ "$SPARK_MASTER_IP" = "" ]; then
     fi
     
     if [ "$START_TACHYON" == "true" ]; then
    -  "$sbin/slaves.sh" cd "$SPARK_HOME" \; "$sbin"/../tachyon/bin/tachyon bootstrap-conf "$SPARK_MASTER_IP"
    +  "${SPARK_HOME}/sbin/slaves.sh" cd "$SPARK_HOME" \; "${SPARK_HOME}/sbin"/../tachyon/bin/tachyon bootstrap-conf "$SPARK_MASTER_IP"
    --- End diff --
    
    @jerryshao do you have time to review my last comment there? quite close here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org