You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/18 07:38:26 UTC

[GitHub] [incubator-dolphinscheduler] z7658329 opened a new issue #4481: [Feature][dolphinscheduler-api] ProcessDefinitionController save API returns ProcessDefinitionId

z7658329 opened a new issue #4481:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4481


   current ProcessDefinitionController   save API didn't returns a new ProcessDefinition's ID,if use API to create ProcessDefinition ,the default release_state is  0(off_line) and no   ProcessDefinitionId returns, so if i want this ProcessDefinition online, i must call query Api to get the ProcessDefinition,then  call  release API to make the ProcessDefinition  online
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] z7658329 commented on issue #4481: [Feature][dolphinscheduler-api] ProcessDefinitionController save API returns ProcessDefinitionId

Posted by GitBox <gi...@apache.org>.
z7658329 commented on issue #4481:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4481#issuecomment-762058102


   > I found that the dev branch has fixed your requirement,It returns processdefinitionid after the workflow definition is saved successfully.
   
   i see,
   ![image](https://user-images.githubusercontent.com/5474723/104886647-0d25f780-59a5-11eb-8a0a-c860350d45d3.png)
   
   but is the implementation suitable? why not only return processDefineId? and  if so,why should query DB?and  if return the processDefine Entity,will Impact on Performance? 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] lenboo commented on issue #4481: [Feature][dolphinscheduler-api] ProcessDefinitionController save API returns ProcessDefinitionId

Posted by GitBox <gi...@apache.org>.
lenboo commented on issue #4481:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4481#issuecomment-762086076


   > > I found that the dev branch has fixed your requirement,It returns processdefinitionid after the workflow definition is saved successfully.
   > 
   > i see,
   > ![image](https://user-images.githubusercontent.com/5474723/104886647-0d25f780-59a5-11eb-8a0a-c860350d45d3.png)
   > 
   > but is the implementation suitable? why not only return processDefineId? and if so,why should query DB?and if return the processDefine Entity,will Impact on Performance?
   
   My understanding is that you want to put definition in the result.
   and what's the use of that? Can you give some examples?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] CalvinKirs closed issue #4481: [Feature][dolphinscheduler-api] ProcessDefinitionController save API returns ProcessDefinitionId

Posted by GitBox <gi...@apache.org>.
CalvinKirs closed issue #4481:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4481


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] zhuangchong commented on issue #4481: [Feature][dolphinscheduler-api] ProcessDefinitionController save API returns ProcessDefinitionId

Posted by GitBox <gi...@apache.org>.
zhuangchong commented on issue #4481:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4481#issuecomment-762053228


   I found that the dev branch has fixed your requirement,It returns processdefinitionid after the workflow definition is saved successfully.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] z7658329 commented on issue #4481: [Feature][dolphinscheduler-api] ProcessDefinitionController save API returns ProcessDefinitionId

Posted by GitBox <gi...@apache.org>.
z7658329 commented on issue #4481:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4481#issuecomment-762050108


   i have fork the git and fix the bug,lets contact in WeChat


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org