You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/23 12:32:21 UTC
[GitHub] [camel-k] nicolaferraro opened a new issue #1710: Generate CRD schema for Kamelet + KameletBinding
nicolaferraro opened a new issue #1710:
URL: https://github.com/apache/camel-k/issues/1710
Any idea why it's not generated? Maybe for the different api version? @astefanutti
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] nicolaferraro closed issue #1710: Generate CRD schema for Kamelet + KameletBinding
Posted by GitBox <gi...@apache.org>.
nicolaferraro closed issue #1710:
URL: https://github.com/apache/camel-k/issues/1710
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on issue #1710: Generate CRD schema for Kamelet + KameletBinding
Posted by GitBox <gi...@apache.org>.
astefanutti commented on issue #1710:
URL: https://github.com/apache/camel-k/issues/1710#issuecomment-697349814
It seems there are errors while generating the CRDs for the `jsonschema_types.go` file:
```
$ make generate-crd
./script/gen_crd.sh
Generating CRDs...
go: downloading sigs.k8s.io/controller-tools v0.0.0-20200528125929-5c0c6ae3b64b
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:65:24: unsupported type "float64"
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:67:24: unsupported type "float64"
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:75:24: unsupported type "float64"
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:200:2: encountered struct field "Schema" without JSON tag in type "JSONSchemaPropsOrArray"
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:201:2: encountered struct field "JSONSchemas" without JSON tag in type "JSONSchemaPropsOrArray"
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:220:2: encountered struct field "Allows" without JSON tag in type "JSONSchemaPropsOrBool"
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:221:2: encountered struct field "Schema" without JSON tag in type "JSONSchemaPropsOrBool"
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:242:2: encountered struct field "Schema" without JSON tag in type "JSONSchemaPropsOrStringArray"
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:243:2: encountered struct field "Property" without JSON tag in type "JSONSchemaPropsOrStringArray"
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:65:24: unsupported type "float64"
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:67:24: unsupported type "float64"
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:75:24: unsupported type "float64"
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:200:2: encountered struct field "Schema" without JSON tag in type "JSONSchemaPropsOrArray"
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:201:2: encountered struct field "JSONSchemas" without JSON tag in type "JSONSchemaPropsOrArray"
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:220:2: encountered struct field "Allows" without JSON tag in type "JSONSchemaPropsOrBool"
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:221:2: encountered struct field "Schema" without JSON tag in type "JSONSchemaPropsOrBool"
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:242:2: encountered struct field "Schema" without JSON tag in type "JSONSchemaPropsOrStringArray"
/Users/astefanu/Development/camel-k/pkg/apis/camel/v1alpha1/jsonschema_types.go:243:2: encountered struct field "Property" without JSON tag in type "JSONSchemaPropsOrStringArray"
Error: not all generators ran successfully
run `controller-gen crd paths=./... output:crd:dir=../../../deploy/crds crd:crdVersions=v1beta1 -w` to see all available markers, or `controller-gen crd paths=./... output:crd:dir=../../../deploy/crds crd:crdVersions=v1beta1 -h` for usage
exit status 1
make: *** [generate-crd] Error 1
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] nicolaferraro commented on issue #1710: Generate CRD schema for Kamelet + KameletBinding
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on issue #1710:
URL: https://github.com/apache/camel-k/issues/1710#issuecomment-697357866
Oh, I though it was bound to the `generate` command and doing nothing.. this is a better error.. thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on issue #1710: Generate CRD schema for Kamelet + KameletBinding
Posted by GitBox <gi...@apache.org>.
astefanutti commented on issue #1710:
URL: https://github.com/apache/camel-k/issues/1710#issuecomment-697364035
Ah right, the `generate-crd` target should probably ultimately be run as part of the `generate` one. There is still a manually step to rename the CRD file names, and a few clean-up IIRC, that is why I did not added it yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org