You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@syncope.apache.org by il...@apache.org on 2013/04/17 11:17:14 UTC
svn commit: r1468807 - in
/syncope/branches/1_1_X/core/src/main/java/org/apache/syncope/core:
propagation/impl/PropagationManager.java util/AttributableUtil.java
Author: ilgrosso
Date: Wed Apr 17 09:17:14 2013
New Revision: 1468807
URL: http://svn.apache.org/r1468807
Log:
[SYNCOPE-359] Not generating PropagationTask instances when no mapping is provided
Modified:
syncope/branches/1_1_X/core/src/main/java/org/apache/syncope/core/propagation/impl/PropagationManager.java
syncope/branches/1_1_X/core/src/main/java/org/apache/syncope/core/util/AttributableUtil.java
Modified: syncope/branches/1_1_X/core/src/main/java/org/apache/syncope/core/propagation/impl/PropagationManager.java
URL: http://svn.apache.org/viewvc/syncope/branches/1_1_X/core/src/main/java/org/apache/syncope/core/propagation/impl/PropagationManager.java?rev=1468807&r1=1468806&r2=1468807&view=diff
==============================================================================
--- syncope/branches/1_1_X/core/src/main/java/org/apache/syncope/core/propagation/impl/PropagationManager.java (original)
+++ syncope/branches/1_1_X/core/src/main/java/org/apache/syncope/core/propagation/impl/PropagationManager.java Wed Apr 17 09:17:14 2013
@@ -549,6 +549,9 @@ public class PropagationManager {
final ExternalResource resource = resourceDAO.find(resourceName);
if (resource == null) {
LOG.error("Invalid resource name specified: {}, ignoring...", resourceName);
+ } else if (attrUtil.getMappingItems(resource, MappingPurpose.PROPAGATION).isEmpty()) {
+ LOG.warn("Requesting propagation for {} but no propagation mapping provided for {}",
+ attrUtil.getType(), resource);
} else {
PropagationTask task = new PropagationTask();
task.setResource(resource);
Modified: syncope/branches/1_1_X/core/src/main/java/org/apache/syncope/core/util/AttributableUtil.java
URL: http://svn.apache.org/viewvc/syncope/branches/1_1_X/core/src/main/java/org/apache/syncope/core/util/AttributableUtil.java?rev=1468807&r1=1468806&r2=1468807&view=diff
==============================================================================
--- syncope/branches/1_1_X/core/src/main/java/org/apache/syncope/core/util/AttributableUtil.java (original)
+++ syncope/branches/1_1_X/core/src/main/java/org/apache/syncope/core/util/AttributableUtil.java Wed Apr 17 09:17:14 2013
@@ -202,7 +202,8 @@ public class AttributableUtil {
public <T extends AbstractMappingItem> List<T> getMappingItems(
final ExternalResource resource, final MappingPurpose purpose) {
- List<T> items = Collections.EMPTY_LIST;
+
+ List<T> items = Collections.<T>emptyList();
if (resource != null) {
switch (type) {