[GitHub] [airflow] malthe commented on pull request #19361: Implement task-level include/exclude time filter

[GitBox <gi...@apache.org>]

malthe commented on pull request #19361:
URL: https://github.com/apache/airflow/pull/19361#issuecomment-957545051


   @kaxil while I think the functionality could be baked into trigger rules, I can see two problems with that:
   
   1. How would the API look? Today you have something like 
   
       ```python
       my_task = PythonOperator(
           task_id='my_task',
           trigger_rule='all_success'
       )
       ```
       Something like `trigger_rule={"state": "all_success", "include_date": ...}` – ?
   
       I think the interface suggested in this pull request fits better with the existing `start_date` and `end_date` parameters.
   
   2. The `include_date` and `exclude_date` parameters match on the DAG run (specifically, the execution date) and are not tied to the task dependencies (unlike trigger rules).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org