You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/03/02 22:45:51 UTC
Re: Review Request 43630: Especially updated scheduler tests to use
the updated MesosTest helpers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43630/
-----------------------------------------------------------
(Updated March 2, 2016, 1:45 p.m.)
Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
Changes
-------
Propagating changes due to the reintroduction of the Try<> in the factory method's return type.
Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634
Repository: mesos
Description
-------
Continuation of https://reviews.apache.org/r/43615/ with re-ordering of some local variables due to the order of destruction.
Diffs (updated)
-----
src/tests/master_maintenance_tests.cpp 3faa8136cf57276295553910319480028f433e4c
src/tests/scheduler_tests.cpp 2b1693eaf1a6106f5e7d269e4e3f6c353dd6f017
Diff: https://reviews.apache.org/r/43630/diff/
Testing
-------
Tests are run at the end of this review chain.
Thanks,
Joseph Wu
Re: Review Request 43630: Especially updated scheduler tests to use
the updated MesosTest helpers.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43630/#review123864
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On March 14, 2016, 9:32 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43630/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 9:32 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
>
>
> Bugs: MESOS-4633 and MESOS-4634
> https://issues.apache.org/jira/browse/MESOS-4633
> https://issues.apache.org/jira/browse/MESOS-4634
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Continuation of https://reviews.apache.org/r/43615/ with re-ordering of some local variables due to the order of destruction.
>
>
> Diffs
> -----
>
> src/tests/master_maintenance_tests.cpp 1dce98bebcd920de53124b1dde10c2067bfc4020
> src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4
>
> Diff: https://reviews.apache.org/r/43630/diff/
>
>
> Testing
> -------
>
> Tests are run at the end of this review chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 43630: Especially updated scheduler tests to use
the updated MesosTest helpers.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43630/
-----------------------------------------------------------
(Updated March 14, 2016, 2:32 p.m.)
Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
Changes
-------
Rebase and update MasterMaintenanceTest changes. Also modified the new EndpointsBadAuthentication test.
Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634
Repository: mesos
Description
-------
Continuation of https://reviews.apache.org/r/43615/ with re-ordering of some local variables due to the order of destruction.
Diffs (updated)
-----
src/tests/master_maintenance_tests.cpp 1dce98bebcd920de53124b1dde10c2067bfc4020
src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4
Diff: https://reviews.apache.org/r/43630/diff/
Testing
-------
Tests are run at the end of this review chain.
Thanks,
Joseph Wu
Re: Review Request 43630: Especially updated scheduler tests to use
the updated MesosTest helpers.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43630/
-----------------------------------------------------------
(Updated March 11, 2016, 10:24 a.m.)
Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
Changes
-------
Rebase on the PendingUnavailabilityTest changes.
Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634
Repository: mesos
Description
-------
Continuation of https://reviews.apache.org/r/43615/ with re-ordering of some local variables due to the order of destruction.
Diffs (updated)
-----
src/tests/master_maintenance_tests.cpp 3c7024cfbd7e5bef75f092eace8d0e80000ca423
src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4
Diff: https://reviews.apache.org/r/43630/diff/
Testing
-------
Tests are run at the end of this review chain.
Thanks,
Joseph Wu
Re: Review Request 43630: Especially updated scheduler tests to use
the updated MesosTest helpers.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43630/
-----------------------------------------------------------
(Updated March 10, 2016, 12:28 p.m.)
Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
Changes
-------
Rename `detector()` to `createDetector()`.
Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634
Repository: mesos
Description
-------
Continuation of https://reviews.apache.org/r/43615/ with re-ordering of some local variables due to the order of destruction.
Diffs (updated)
-----
src/tests/master_maintenance_tests.cpp 3faa8136cf57276295553910319480028f433e4c
src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4
Diff: https://reviews.apache.org/r/43630/diff/
Testing
-------
Tests are run at the end of this review chain.
Thanks,
Joseph Wu
Re: Review Request 43630: Especially updated scheduler tests to use
the updated MesosTest helpers.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43630/
-----------------------------------------------------------
(Updated March 8, 2016, 2:32 p.m.)
Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
Changes
-------
Whitespace change from a comment in the next review.
Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634
Repository: mesos
Description
-------
Continuation of https://reviews.apache.org/r/43615/ with re-ordering of some local variables due to the order of destruction.
Diffs (updated)
-----
src/tests/master_maintenance_tests.cpp 3faa8136cf57276295553910319480028f433e4c
src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4
Diff: https://reviews.apache.org/r/43630/diff/
Testing
-------
Tests are run at the end of this review chain.
Thanks,
Joseph Wu
Re: Review Request 43630: Especially updated scheduler tests to use
the updated MesosTest helpers.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43630/
-----------------------------------------------------------
(Updated March 4, 2016, 3:58 p.m.)
Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
Changes
-------
Rebase and update scheduler tests. These used to have some special changes, but now look pretty much identical to the changes in the next review (Thanks Anand!)
Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634
Repository: mesos
Description
-------
Continuation of https://reviews.apache.org/r/43615/ with re-ordering of some local variables due to the order of destruction.
Diffs (updated)
-----
src/tests/master_maintenance_tests.cpp 3faa8136cf57276295553910319480028f433e4c
src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4
Diff: https://reviews.apache.org/r/43630/diff/
Testing
-------
Tests are run at the end of this review chain.
Thanks,
Joseph Wu
Re: Review Request 43630: Especially updated scheduler tests to use
the updated MesosTest helpers.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43630/#review122079
-----------------------------------------------------------
Ship it!
- Bernd Mathiske
On March 2, 2016, 1:45 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43630/
> -----------------------------------------------------------
>
> (Updated March 2, 2016, 1:45 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
>
>
> Bugs: MESOS-4633 and MESOS-4634
> https://issues.apache.org/jira/browse/MESOS-4633
> https://issues.apache.org/jira/browse/MESOS-4634
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Continuation of https://reviews.apache.org/r/43615/ with re-ordering of some local variables due to the order of destruction.
>
>
> Diffs
> -----
>
> src/tests/master_maintenance_tests.cpp 3faa8136cf57276295553910319480028f433e4c
> src/tests/scheduler_tests.cpp 2b1693eaf1a6106f5e7d269e4e3f6c353dd6f017
>
> Diff: https://reviews.apache.org/r/43630/diff/
>
>
> Testing
> -------
>
> Tests are run at the end of this review chain.
>
>
> Thanks,
>
> Joseph Wu
>
>