You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Xu-Wentao (via GitHub)" <gi...@apache.org> on 2023/05/16 10:46:31 UTC
[GitHub] [shardingsphere-on-cloud] Xu-Wentao opened a new pull request, #365: fix(pitr): fix pitr restore metadata failed
Xu-Wentao opened a new pull request, #365:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/365
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
If there's some quotation marks in metadata, import metadata into sharingsphere may failed.
ShardingSphere now support export metadata encoded by base64: https://github.com/apache/shardingsphere/pull/25691
Decode metadata when export from shardingsphere and save to local, and encode metadta from local when import metadata.
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Test is required for the feat/fix PR, unless you have a good reason
2. Doc is required for the feat PR
3. Use "request review" to notify the reviewer once you have resolved the review
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] wbtlb commented on pull request #365: fix(pitr): fix pitr restore metadata failed
Posted by "wbtlb (via GitHub)" <gi...@apache.org>.
wbtlb commented on PR #365:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/365#issuecomment-1549455081
approve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #365: fix(pitr): fix pitr restore metadata failed
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #365:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/365#issuecomment-1549432837
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=365)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=365) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=365&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=365&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] codecov-commenter commented on pull request #365: fix(pitr): fix pitr restore metadata failed
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #365:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/365#issuecomment-1549434302
## [Codecov](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/365?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#365](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/365?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0d53b8a) into [main](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/commit/073095776d1b16442d0a5ebc7e34d72c7d45bf36?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0730957) will **increase** coverage by `3.05%`.
> The diff coverage is `45.95%`.
> :exclamation: Current head 0d53b8a differs from pull request most recent head 7fc4746. Consider uploading reports for the commit 7fc4746 to get more accurate results
```diff
@@ Coverage Diff @@
## main #365 +/- ##
==========================================
+ Coverage 41.67% 44.72% +3.05%
==========================================
Files 44 46 +2
Lines 4773 4923 +150
==========================================
+ Hits 1989 2202 +213
+ Misses 2631 2523 -108
- Partials 153 198 +45
```
| [Impacted Files](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ator/cmd/shardingsphere-operator/manager/option.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvY21kL3NoYXJkaW5nc3BoZXJlLW9wZXJhdG9yL21hbmFnZXIvb3B0aW9uLmdv) | `49.52% <0.00%> (+2.67%)` | :arrow_up: |
| [...pkg/controllers/shardingsphere\_chaos\_controller.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXJzL3NoYXJkaW5nc3BoZXJlX2NoYW9zX2NvbnRyb2xsZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [...rator/pkg/reconcile/storagenode/aws/rdsinstance.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL3JlY29uY2lsZS9zdG9yYWdlbm9kZS9hd3MvcmRzaW5zdGFuY2UuZ28=) | `22.79% <ø> (+0.33%)` | :arrow_up: |
| [pitr/cli/internal/pkg/shardingsphere-proxy.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGl0ci9jbGkvaW50ZXJuYWwvcGtnL3NoYXJkaW5nc3BoZXJlLXByb3h5Lmdv) | `15.51% <33.33%> (+15.51%)` | :arrow_up: |
| [...here-operator/pkg/shardingsphere/shardingsphere.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc3BoZXJlLmdv) | `44.55% <44.55%> (ø)` | |
| [...perator/pkg/controllers/storage\_node\_controller.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXJzL3N0b3JhZ2Vfbm9kZV9jb250cm9sbGVyLmdv) | `47.25% <51.26%> (+6.59%)` | :arrow_up: |
| [shardingsphere-operator/pkg/pressure/pressure.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL3ByZXNzdXJlL3ByZXNzdXJlLmdv) | `75.22% <75.22%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #365: fix(pitr): fix pitr restore metadata failed
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #365:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/365#issuecomment-1549428733
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=365)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=365&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=365) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=365&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=365&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] mlycore merged pull request #365: fix(pitr): fix pitr restore metadata failed
Posted by "mlycore (via GitHub)" <gi...@apache.org>.
mlycore merged PR #365:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org