You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/06/10 11:15:34 UTC

[GitHub] [tinkerpop] spmallette commented on a change in pull request #1293: TINKERPOP-2264 update gremlin-python tests to be timezone/system-independent, related minor Docker changes

spmallette commented on a change in pull request #1293:
URL: https://github.com/apache/tinkerpop/pull/1293#discussion_r438045632



##########
File path: gremlin-python/pom.xml
##########
@@ -311,7 +311,7 @@ limitations under the License.
                                             <fileset dir="src/main/jython"/>
                                         </copy>
                                         <!-- print versions of python and virtualenv -->
-                                        <exec dir="${project.build.directory}/python2" executable="python2"
+                                        <exec dir="${project.build.directory}/python2" executable="python"

Review comment:
       I think I'd like to keep the same assumptions we've always had about local dev environments as we're deep into 3.4.x at this point and python2 is gone in 3.5.0. Do you mind reverting this change and doing a alias or something in your environment locally to accommodate this configuration?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org