[GitHub] [apisix-ingress-controller] lingsamuel commented on a diff in pull request #1216: fix: log Secret name instead of all data

[GitBox <gi...@apache.org>]

lingsamuel commented on code in PR #1216:
URL: https://github.com/apache/apisix-ingress-controller/pull/1216#discussion_r945589277


##########
pkg/providers/k8s/secret.go:
##########
@@ -400,8 +400,8 @@ func (c *secretController) onUpdate(prev, curr interface{}) {
 		return
 	}
 	log.Debugw("secret update event arrived",
-		zap.Any("new object", curr),
-		zap.Any("old object", prev),
+		zap.Any("new object", curr.(*corev1.Secret).ObjectMeta.Name),
+		zap.Any("old object", prev.(*corev1.Secret).ObjectMeta.Name),

Review Comment:
   we don't need to log secret name twice since it is immutable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org