[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36451: [SPARK-39100][CORE] RDD `DeterministicLevel` needs backward compatibility

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on code in PR #36451:
URL: https://github.com/apache/spark/pull/36451#discussion_r866400346


##########
core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala:
##########
@@ -280,4 +276,12 @@ private[spark] object RDDOperationGraph extends Logging {
     }
     subgraph.append(indent).append("}\n")
   }
+
+  def formatDeterministicLevel(node: RDDOperationNode): String = {
+    node.outputDeterministicLevel match {
+      case DeterministicLevel.INDETERMINATE => " [Indeterminate]"
+      case DeterministicLevel.UNORDERED => " [Unordered]"
+      case _ => ""

Review Comment:
   This could be a root cause of future bug. Please follow the existing way by adding back `case DeterministicLevel.DETERMINATE => ""` and raises Exception explicitly for unmatched case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org