You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by do...@apache.org on 2017/09/20 04:19:24 UTC

incubator-rocketmq git commit: [ROCKETMQ-273] return an expression when a function has no write operations.

Repository: incubator-rocketmq
Updated Branches:
  refs/heads/develop 368e7c86a -> 27a678de3


[ROCKETMQ-273] return an expression when a function has no write operations.

Author: wangkai <87...@qq.com>

Closes #150 from kevin-better/develop.


Project: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq/commit/27a678de
Tree: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq/tree/27a678de
Diff: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq/diff/27a678de

Branch: refs/heads/develop
Commit: 27a678de3c592f4b87c4284bba64b2d50d966785
Parents: 368e7c8
Author: wangkai <87...@qq.com>
Authored: Wed Sep 20 12:19:15 2017 +0800
Committer: dongeforever <do...@apache.org>
Committed: Wed Sep 20 12:19:15 2017 +0800

----------------------------------------------------------------------
 .../java/org/apache/rocketmq/store/DefaultMessageStore.java  | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-rocketmq/blob/27a678de/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
----------------------------------------------------------------------
diff --git a/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java b/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
index 59ef490..192d097 100644
--- a/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
+++ b/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
@@ -416,12 +416,8 @@ public class DefaultMessageStore implements MessageStore {
         long begin = this.getCommitLog().getBeginTimeInLock();
         long diff = this.systemClock.now() - begin;
 
-        if (diff < 10000000
-            && diff > this.messageStoreConfig.getOsPageCacheBusyTimeOutMills()) {
-            return true;
-        }
-
-        return false;
+        return diff < 10000000
+                && diff > this.messageStoreConfig.getOsPageCacheBusyTimeOutMills();
     }
 
     @Override