You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2020/05/03 17:00:58 UTC

[GitHub] [struts] JCgH4164838Gh792C124B5 opened a new pull request #413: Proposed WW-5074 Fix

JCgH4164838Gh792C124B5 opened a new pull request #413:
URL: https://github.com/apache/struts/pull/413


   Proposed WW-5074 Fix:
   - Exclude ASM 3.3.1 from inclusion as a dependency for commons-digester3 (also mark commons-digester3 as optional dependency since it is only listed to allow the exclusion).
   - Provide explicit test dependency of ASM 3.3.1 for portlet-plugin (otherwise its jmock tests are unable to execute).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #413: Proposed WW-5074 Fix

Posted by GitBox <gi...@apache.org>.
JCgH4164838Gh792C124B5 commented on pull request #413:
URL: https://github.com/apache/struts/pull/413#issuecomment-623146394


   Hello Apache Struts Team.
   
   This PR attempts to fix the ASM version conflict issue (two jars with different versions, groupId changed after ASM 3.x) found after deploying the Struts Showcase applications.
   
   This seemed to be the only combination of changes that both avoided the extra jar and resulted in a successful build.  More experienced Maven users might have a better strategy - please let me know if you do.  :smile:


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [struts] coveralls commented on pull request #413: Proposed WW-5074 Fix

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #413:
URL: https://github.com/apache/struts/pull/413#issuecomment-623146326


   
   [![Coverage Status](https://coveralls.io/builds/30522553/badge)](https://coveralls.io/builds/30522553)
   
   Coverage remained the same at 49.176% when pulling **a6711251a68dea3f3ac89524fc65f59c7700cb15 on JCgH4164838Gh792C124B5:WW-5074_CfgFix** into **0a5399957674b19d589cd5b1069cfc5491bbdd67 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org