[GitHub] flink pull request #4157: [FLINK-6649][table]Improve Non-window group aggreg...

[fhueske <gi...@git.apache.org>]

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4157#discussion_r125281365
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/queryConfig.scala ---
    @@ -37,6 +37,13 @@ class BatchQueryConfig private[table] extends QueryConfig
     class StreamQueryConfig private[table] extends QueryConfig {
     
       /**
    +    * The non-windowed groupby aggregate update the calculation result according a configuration of
    +    * time interval. By default non-windowed groupby aggregate will update calculation result each
    +    * row.
    +    */
    +  private var unboundedAggregateUpdateInterval: Time = Time.milliseconds(0)
    --- End diff --
    
    I would not make this parameter specific for unbounded aggregates but use it for all types of (supported) operators. The output of a query will always be synced to the slowest update rate.
    
    Hence I propose to rename the parameter to `updateRate` or `updateInterval`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---