You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "sreekanth (JIRA)" <ji...@apache.org> on 2011/06/22 20:21:47 UTC
[jira] [Created] (ZOOKEEPER-1104) CLONE - In QuorumTest, use the
same "for ( .. try { break } catch { } )" pattern in
testFollowersStartAfterLeaders as in testSessionMove.
CLONE - In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
-----------------------------------------------------------------------------------------------------------------------------------------
Key: ZOOKEEPER-1104
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1104
Project: ZooKeeper
Issue Type: Improvement
Components: tests
Affects Versions: 3.3.3, 3.4.0
Reporter: sreekanth
Assignee: Eugene Koontz
Priority: Minor
Fix For: 3.3.4, 3.4.0
Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch
Patrick Hunt writes:
"Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
of sleep in testSessionMove in the same class for a better way to do
this. I had gone through all the tests a while back, replacing all the
"sleep(x)" with something like this testSessionMove pattern (retry
with a max limit that's very long). During reviews we should look for
anti-patterns like this and address them before commit."
So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1104) CLONE - In QuorumTest, use the
same "for ( .. try { break } catch { } )" pattern in
testFollowersStartAfterLeaders as in testSessionMove.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082933#comment-13082933 ]
Hadoop QA commented on ZOOKEEPER-1104:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12487200/ZOOKEEPER-1104.patch
against trunk revision 1152141.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/449//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/449//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/449//console
This message is automatically generated.
> CLONE - In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1104
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1104
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: sreekanth
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch, ZOOKEEPER-1104.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1104) CLONE - In QuorumTest, use the
same "for ( .. try { break } catch { } )" pattern in
testFollowersStartAfterLeaders as in testSessionMove.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085025#comment-13085025 ]
Hudson commented on ZOOKEEPER-1104:
-----------------------------------
Integrated in ZooKeeper-trunk #1266 (See [https://builds.apache.org/job/ZooKeeper-trunk/1266/])
ZOOKEEPER-1104. CLONE - In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove. (Eugene Koontz via mahadev)
mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1157690
Files :
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/QuorumTest.java
* /zookeeper/trunk/CHANGES.txt
> CLONE - In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1104
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1104
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.4.0
> Reporter: sreekanth
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch, ZOOKEEPER-1104.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1104) CLONE - In QuorumTest, use the
same "for ( .. try { break } catch { } )" pattern in
testFollowersStartAfterLeaders as in testSessionMove.
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated ZOOKEEPER-1104:
-------------------------------------
Attachment: ZOOKEEPER-1104.patch
> CLONE - In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1104
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1104
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: sreekanth
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch, ZOOKEEPER-1104.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1104) CLONE - In QuorumTest, use the
same "for ( .. try { break } catch { } )" pattern in
testFollowersStartAfterLeaders as in testSessionMove.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-1104:
-------------------------------------
Affects Version/s: (was: 3.3.3)
Fix Version/s: (was: 3.3.4)
> CLONE - In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1104
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1104
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.4.0
> Reporter: sreekanth
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch, ZOOKEEPER-1104.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1104) CLONE - In QuorumTest, use the
same "for ( .. try { break } catch { } )" pattern in
testFollowersStartAfterLeaders as in testSessionMove.
Posted by "sreekanth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053376#comment-13053376 ]
sreekanth commented on ZOOKEEPER-1104:
--------------------------------------
f
> CLONE - In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1104
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1104
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: sreekanth
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1104) CLONE - In QuorumTest, use the
same "for ( .. try { break } catch { } )" pattern in
testFollowersStartAfterLeaders as in testSessionMove.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084925#comment-13084925 ]
Mahadev konar commented on ZOOKEEPER-1104:
------------------------------------------
Eugene, I am assuming the patch is just for trunk. Let me know if it needs to go into 3.3 branch as well.
> CLONE - In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1104
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1104
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.4.0
> Reporter: sreekanth
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch, ZOOKEEPER-1104.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1104) CLONE - In QuorumTest, use the
same "for ( .. try { break } catch { } )" pattern in
testFollowersStartAfterLeaders as in testSessionMove.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068563#comment-13068563 ]
Hadoop QA commented on ZOOKEEPER-1104:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12487200/ZOOKEEPER-1104.patch
against trunk revision 1148553.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
-1 release audit. The applied patch generated 26 release audit warnings (more than the trunk's current 24 warnings).
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/404//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/404//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/404//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/404//console
This message is automatically generated.
> CLONE - In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1104
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1104
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: sreekanth
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch, ZOOKEEPER-1104.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1104) CLONE - In QuorumTest, use the
same "for ( .. try { break } catch { } )" pattern in
testFollowersStartAfterLeaders as in testSessionMove.
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083509#comment-13083509 ]
Eugene Koontz commented on ZOOKEEPER-1104:
------------------------------------------
Hi Mahadev, Please use the ZOOKEEPER-1104 one (ZOOKEEPER-1104.patch)
-Eugene
> CLONE - In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1104
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1104
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: sreekanth
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch, ZOOKEEPER-1104.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1104) CLONE - In QuorumTest, use the
same "for ( .. try { break } catch { } )" pattern in
testFollowersStartAfterLeaders as in testSessionMove.
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068534#comment-13068534 ]
Eugene Koontz commented on ZOOKEEPER-1104:
------------------------------------------
Hi, an earlier version of the patch for this issue is now in trunk since:
I am adding another, smaller patch that syncs trunk with the modifications of this patch (removing the unneeded "boolean success" variable).
> CLONE - In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1104
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1104
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: sreekanth
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1104) CLONE - In QuorumTest, use the
same "for ( .. try { break } catch { } )" pattern in
testFollowersStartAfterLeaders as in testSessionMove.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082963#comment-13082963 ]
Mahadev konar commented on ZOOKEEPER-1104:
------------------------------------------
Eugene,
You have a couple of patches attached. 2 of them saying ZOOKEEPER-1103. Is ZOOKEEPER-1104 patch the one to consider for this jira?
> CLONE - In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1104
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1104
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: sreekanth
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch, ZOOKEEPER-1104.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1104) CLONE - In QuorumTest, use the
same "for ( .. try { break } catch { } )" pattern in
testFollowersStartAfterLeaders as in testSessionMove.
Posted by "Mark Thomas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Thomas updated ZOOKEEPER-1104:
-----------------------------------
Comment: was deleted
(was: f)
> CLONE - In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1104
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1104
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: sreekanth
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch, ZOOKEEPER-1104.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1104) CLONE - In QuorumTest, use the
same "for ( .. try { break } catch { } )" pattern in
testFollowersStartAfterLeaders as in testSessionMove.
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068537#comment-13068537 ]
Eugene Koontz commented on ZOOKEEPER-1104:
------------------------------------------
sorry should have read "since June 21-June 22"
{{
commit 9619bd31d5b191fdb7d622d2bb84fac92ab1111c
Author: Patrick D. Hunt <ph...@apache.org>
Date: Wed Jun 22 19:35:55 2011 +0000
Fixed a problem introduced by the first patch for ZOOKEEPER-1103 (phunt)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1138595 13f79535-47bb-0310-9956-ffa450edef68
commit 77992edd8abc6ffd759d60266e55fd3b388b7d3a
Author: Patrick D. Hunt <ph...@apache.org>
Date: Tue Jun 21 22:19:04 2011 +0000
ZOOKEEPER-1103. In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove. (Eugene Koontz v
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1138213 13f79535-47bb-0310-9956-ffa450edef68
}}
> CLONE - In QuorumTest, use the same "for ( .. try { break } catch { } )" pattern in testFollowersStartAfterLeaders as in testSessionMove.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1104
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1104
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.3, 3.4.0
> Reporter: sreekanth
> Assignee: Eugene Koontz
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1103.patch, ZOOKEEPER-1103_branch_3_3.patch
>
>
> Patrick Hunt writes:
> "Such uses of sleep [used in testFollowersStartAfterLeader] are just asking for trouble. Take a look at the use
> of sleep in testSessionMove in the same class for a better way to do
> this. I had gone through all the tests a while back, replacing all the
> "sleep(x)" with something like this testSessionMove pattern (retry
> with a max limit that's very long). During reviews we should look for
> anti-patterns like this and address them before commit."
> So, modify testFollowersStartAfterLeaders to use the same retrying approach that testSessionMove uses.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira