You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Srinivas Reddy <sr...@gmail.com> on 2018/09/21 08:07:32 UTC
[DISCUSS] KIP-374: Add '--help' option to all available Kafka CLI commands
Hi All,
I'd like to start a discussion on KIP-374 which is to add "--help" option
for all the possible CLI commands in Kafka. right now, few commands support
it and few does not. We brings up this KIP to provide consistent user
experience.
More details added in this KIP page(including code changes):
https://cwiki.apache.org/confluence/display/KAFKA/KIP-374%3A+Add+%27--help%27+option+to+all+available+Kafka+CLI+commands
I look forward to feedback and comments.
--
Srinivas Reddy
http://mrsrinivas.com/
(Sent via gmail web)
Re: [DISCUSS] KIP-374: Add '--help' option to all available Kafka CLI commands
Posted by Srinivas Reddy <sr...@gmail.com>.
Thank you Colin for the response. Any feedback from others?
--
Srinivas Reddy
http://mrsrinivas.com/
(Sent via gmail web)
On Tue, 2 Oct 2018 at 02:18, Colin McCabe <cm...@apache.org> wrote:
> Hi Srinivas,
>
> Thanks for the KIP.
>
> +1 for adding a --help option to all commands that don't already have it.
>
> If everyone agrees, then maybe you can call a vote on this KIP. Once the
> KIP is accepted, then we can accept the corresponding PR. I know it seems
> a bit heavyweight, but we prefer to be conservative when changing public
> command line interfaces.
>
> best,
> Colin
>
> On Sun, Sep 30, 2018, at 21:02, Srinivas Reddy wrote:
> > Hi Dongjin,
> >
> > I have identified most of the code changes for this task. I can raise a
> > GitHub PR if community think this is a good to have feature in Kafka.
> >
> > Should I start working on it?
> >
> > -
> > Srinivas
> >
> > - Typed on tiny keys. pls ignore typos.{mobile app}
> >
> > On Thu 27 Sep, 2018, 14:40 Dongjin Lee, <do...@apache.org> wrote:
> >
> > > Hi Srinivas,
> > >
> > > Thanks for your proposal. It sounds reasonable to me. However, the code
> > > freeze of 2.1.0 is imminent so it seems like all the committers are on
> > > working frenzy on it. How about to postpone reboot this discussion
> after
> > > the release of 2.1.0? I will kick off the thread as soon as the
> release is
> > > completed.
> > >
> > > Thanks,
> > > Dongjin
> > >
> > > On Thu, Sep 27, 2018 at 1:31 PM Srinivas Reddy <
> srinivas96alluri@gmail.com
> > > >
> > > wrote:
> > >
> > > > Any thoughts about this KIP ?
> > > >
> > > > -
> > > > Srinivas
> > > >
> > > > - Typed on tiny keys. pls ignore typos.{mobile app}
> > > >
> > > > On Fri 21 Sep, 2018, 16:07 Srinivas Reddy, <
> srinivas96alluri@gmail.com>
> > > > wrote:
> > > >
> > > > > Hi All,
> > > > >
> > > > > I'd like to start a discussion on KIP-374 which is to add "--help"
> > > option
> > > > > for all the possible CLI commands in Kafka. right now, few commands
> > > > support
> > > > > it and few does not. We brings up this KIP to provide consistent
> user
> > > > > experience.
> > > > >
> > > > > More details added in this KIP page(including code changes):
> > > > >
> > > > >
> > > >
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-374%3A+Add+%27--help%27+option+to+all+available+Kafka+CLI+commands
> > > > >
> > > > > I look forward to feedback and comments.
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Srinivas Reddy
> > > > >
> > > > > http://mrsrinivas.com/
> > > > >
> > > > >
> > > > > (Sent via gmail web)
> > > > >
> > > >
> > >
> > >
> > > --
> > > *Dongjin Lee*
> > >
> > > *A hitchhiker in the mathematical world.*
> > >
> > > *github: <http://goog_969573159/>github.com/dongjinleekr
> > > <http://github.com/dongjinleekr>linkedin:
> kr.linkedin.com/in/dongjinleekr
> > > <http://kr.linkedin.com/in/dongjinleekr>slideshare:
> > > www.slideshare.net/dongjinleekr
> > > <http://www.slideshare.net/dongjinleekr>*
> > >
>
Re: [DISCUSS] KIP-374: Add '--help' option to all available Kafka CLI
commands
Posted by Colin McCabe <cm...@apache.org>.
Hi Srinivas,
Thanks for the KIP.
+1 for adding a --help option to all commands that don't already have it.
If everyone agrees, then maybe you can call a vote on this KIP. Once the KIP is accepted, then we can accept the corresponding PR. I know it seems a bit heavyweight, but we prefer to be conservative when changing public command line interfaces.
best,
Colin
On Sun, Sep 30, 2018, at 21:02, Srinivas Reddy wrote:
> Hi Dongjin,
>
> I have identified most of the code changes for this task. I can raise a
> GitHub PR if community think this is a good to have feature in Kafka.
>
> Should I start working on it?
>
> -
> Srinivas
>
> - Typed on tiny keys. pls ignore typos.{mobile app}
>
> On Thu 27 Sep, 2018, 14:40 Dongjin Lee, <do...@apache.org> wrote:
>
> > Hi Srinivas,
> >
> > Thanks for your proposal. It sounds reasonable to me. However, the code
> > freeze of 2.1.0 is imminent so it seems like all the committers are on
> > working frenzy on it. How about to postpone reboot this discussion after
> > the release of 2.1.0? I will kick off the thread as soon as the release is
> > completed.
> >
> > Thanks,
> > Dongjin
> >
> > On Thu, Sep 27, 2018 at 1:31 PM Srinivas Reddy <srinivas96alluri@gmail.com
> > >
> > wrote:
> >
> > > Any thoughts about this KIP ?
> > >
> > > -
> > > Srinivas
> > >
> > > - Typed on tiny keys. pls ignore typos.{mobile app}
> > >
> > > On Fri 21 Sep, 2018, 16:07 Srinivas Reddy, <sr...@gmail.com>
> > > wrote:
> > >
> > > > Hi All,
> > > >
> > > > I'd like to start a discussion on KIP-374 which is to add "--help"
> > option
> > > > for all the possible CLI commands in Kafka. right now, few commands
> > > support
> > > > it and few does not. We brings up this KIP to provide consistent user
> > > > experience.
> > > >
> > > > More details added in this KIP page(including code changes):
> > > >
> > > >
> > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-374%3A+Add+%27--help%27+option+to+all+available+Kafka+CLI+commands
> > > >
> > > > I look forward to feedback and comments.
> > > >
> > > >
> > > >
> > > > --
> > > > Srinivas Reddy
> > > >
> > > > http://mrsrinivas.com/
> > > >
> > > >
> > > > (Sent via gmail web)
> > > >
> > >
> >
> >
> > --
> > *Dongjin Lee*
> >
> > *A hitchhiker in the mathematical world.*
> >
> > *github: <http://goog_969573159/>github.com/dongjinleekr
> > <http://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr
> > <http://kr.linkedin.com/in/dongjinleekr>slideshare:
> > www.slideshare.net/dongjinleekr
> > <http://www.slideshare.net/dongjinleekr>*
> >
Re: [DISCUSS] KIP-374: Add '--help' option to all available Kafka CLI commands
Posted by Srinivas Reddy <sr...@gmail.com>.
Hi Dongjin,
I have identified most of the code changes for this task. I can raise a
GitHub PR if community think this is a good to have feature in Kafka.
Should I start working on it?
-
Srinivas
- Typed on tiny keys. pls ignore typos.{mobile app}
On Thu 27 Sep, 2018, 14:40 Dongjin Lee, <do...@apache.org> wrote:
> Hi Srinivas,
>
> Thanks for your proposal. It sounds reasonable to me. However, the code
> freeze of 2.1.0 is imminent so it seems like all the committers are on
> working frenzy on it. How about to postpone reboot this discussion after
> the release of 2.1.0? I will kick off the thread as soon as the release is
> completed.
>
> Thanks,
> Dongjin
>
> On Thu, Sep 27, 2018 at 1:31 PM Srinivas Reddy <srinivas96alluri@gmail.com
> >
> wrote:
>
> > Any thoughts about this KIP ?
> >
> > -
> > Srinivas
> >
> > - Typed on tiny keys. pls ignore typos.{mobile app}
> >
> > On Fri 21 Sep, 2018, 16:07 Srinivas Reddy, <sr...@gmail.com>
> > wrote:
> >
> > > Hi All,
> > >
> > > I'd like to start a discussion on KIP-374 which is to add "--help"
> option
> > > for all the possible CLI commands in Kafka. right now, few commands
> > support
> > > it and few does not. We brings up this KIP to provide consistent user
> > > experience.
> > >
> > > More details added in this KIP page(including code changes):
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-374%3A+Add+%27--help%27+option+to+all+available+Kafka+CLI+commands
> > >
> > > I look forward to feedback and comments.
> > >
> > >
> > >
> > > --
> > > Srinivas Reddy
> > >
> > > http://mrsrinivas.com/
> > >
> > >
> > > (Sent via gmail web)
> > >
> >
>
>
> --
> *Dongjin Lee*
>
> *A hitchhiker in the mathematical world.*
>
> *github: <http://goog_969573159/>github.com/dongjinleekr
> <http://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr
> <http://kr.linkedin.com/in/dongjinleekr>slideshare:
> www.slideshare.net/dongjinleekr
> <http://www.slideshare.net/dongjinleekr>*
>
Re: [DISCUSS] KIP-374: Add '--help' option to all available Kafka CLI commands
Posted by Dongjin Lee <do...@apache.org>.
Hi Srinivas,
Thanks for your proposal. It sounds reasonable to me. However, the code
freeze of 2.1.0 is imminent so it seems like all the committers are on
working frenzy on it. How about to postpone reboot this discussion after
the release of 2.1.0? I will kick off the thread as soon as the release is
completed.
Thanks,
Dongjin
On Thu, Sep 27, 2018 at 1:31 PM Srinivas Reddy <sr...@gmail.com>
wrote:
> Any thoughts about this KIP ?
>
> -
> Srinivas
>
> - Typed on tiny keys. pls ignore typos.{mobile app}
>
> On Fri 21 Sep, 2018, 16:07 Srinivas Reddy, <sr...@gmail.com>
> wrote:
>
> > Hi All,
> >
> > I'd like to start a discussion on KIP-374 which is to add "--help" option
> > for all the possible CLI commands in Kafka. right now, few commands
> support
> > it and few does not. We brings up this KIP to provide consistent user
> > experience.
> >
> > More details added in this KIP page(including code changes):
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-374%3A+Add+%27--help%27+option+to+all+available+Kafka+CLI+commands
> >
> > I look forward to feedback and comments.
> >
> >
> >
> > --
> > Srinivas Reddy
> >
> > http://mrsrinivas.com/
> >
> >
> > (Sent via gmail web)
> >
>
--
*Dongjin Lee*
*A hitchhiker in the mathematical world.*
*github: <http://goog_969573159/>github.com/dongjinleekr
<http://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr
<http://kr.linkedin.com/in/dongjinleekr>slideshare:
www.slideshare.net/dongjinleekr
<http://www.slideshare.net/dongjinleekr>*
Re: [DISCUSS] KIP-374: Add '--help' option to all available Kafka CLI commands
Posted by Srinivas Reddy <sr...@gmail.com>.
Any thoughts about this KIP ?
-
Srinivas
- Typed on tiny keys. pls ignore typos.{mobile app}
On Fri 21 Sep, 2018, 16:07 Srinivas Reddy, <sr...@gmail.com>
wrote:
> Hi All,
>
> I'd like to start a discussion on KIP-374 which is to add "--help" option
> for all the possible CLI commands in Kafka. right now, few commands support
> it and few does not. We brings up this KIP to provide consistent user
> experience.
>
> More details added in this KIP page(including code changes):
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-374%3A+Add+%27--help%27+option+to+all+available+Kafka+CLI+commands
>
> I look forward to feedback and comments.
>
>
>
> --
> Srinivas Reddy
>
> http://mrsrinivas.com/
>
>
> (Sent via gmail web)
>