[jira] [Comment Edited] (YUNIKORN-526) Remove allocations count in the partition

["Manikandan R (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276182#comment-17276182 ] 

Manikandan R edited comment on YUNIKORN-526 at 2/1/21, 9:38 AM:
----------------------------------------------------------------

In general, sync/atomic package is more appropriate for handling cases like this 

https://github.com/apache/incubator-yunikorn-core/pull/242/files#diff-e09ef6f5c0e4efd327afd240d335188fdb9d758af225dc958f0687257c75333eR905

instead of using locks for performance reasons. Thoughts?


was (Author: manirajv06@gmail.com):
In general, sync/atomic package is more appropriate for handling cases like this instead of using locks for performance reasons. Thoughts?

> Remove allocations count in the partition
> -----------------------------------------
>
>                 Key: YUNIKORN-526
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-526
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: core - scheduler
>            Reporter: Weiwei Yang
>            Priority: Trivial
>
> YUNIKORN-461 removes the allocations map from the partition, but it still left an allocations count. That means when we add or remove allocations, we have to update this count in the partition too. I think we can remove that and reimplement GetTotalAllocationCount(), and simply loop all the apps and sum allocations of all apps. Some more discussion can be found here: https://github.com/apache/incubator-yunikorn-core/pull/242#discussion_r566452486



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org