You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@gmail.com> on 2014/04/23 22:49:12 UTC

Review Request 20631: Add Host: checkbox "client" without upper case letter

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20631/
-----------------------------------------------------------

Review request for Ambari and Yusaku Sako.


Bugs: AMBARI-5551
    https://issues.apache.org/jira/browse/AMBARI-5551


Repository: ambari


Description
-------

This patch reverts the label name "client" to "Client" and "HBase RegionServer" to "RegionServer". 
Also this patch might result in changing these labels at other places in the ui.


Diffs
-----

  ambari-web/app/utils/helper.js 9b7297b 

Diff: https://reviews.apache.org/r/20631/diff/


Testing
-------


Thanks,

Jaimin Jetly


Re: Review Request 20631: Add Host: checkbox "client" without upper case letter

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20631/#review41237
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On April 23, 2014, 10:30 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20631/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 10:30 p.m.)
> 
> 
> Review request for Ambari and Yusaku Sako.
> 
> 
> Bugs: AMBARI-5551
>     https://issues.apache.org/jira/browse/AMBARI-5551
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch reverts the label name "client" to "Client" and "HBase RegionServer" to "RegionServer". 
> Also this patch might result in changing these labels at other places in the ui.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/data/wizard/stack/hdp/version1.3.0/HBASE.json c58ce95 
>   ambari-web/app/assets/data/wizard/stack/hdp/version131/HBASE.json 6aa748b 
>   ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/HBASE.json a4bd060 
>   ambari-web/app/data/HDP2/global_properties.js cf5fbaf 
>   ambari-web/app/data/HDP2/secure_properties.js fae3623 
>   ambari-web/app/data/HDP2/site_properties.js 448621a 
>   ambari-web/app/data/global_properties.js 56e9831 
>   ambari-web/app/data/secure_properties.js 572624f 
>   ambari-web/app/data/site_properties.js fca3537 
>   ambari-web/app/messages.js f939538 
>   ambari-web/app/utils/helper.js 9b7297b 
> 
> Diff: https://reviews.apache.org/r/20631/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Re: Review Request 20631: Add Host: checkbox "client" without upper case letter

Posted by Jaimin Jetly <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20631/
-----------------------------------------------------------

(Updated April 23, 2014, 10:30 p.m.)


Review request for Ambari and Yusaku Sako.


Bugs: AMBARI-5551
    https://issues.apache.org/jira/browse/AMBARI-5551


Repository: ambari


Description
-------

This patch reverts the label name "client" to "Client" and "HBase RegionServer" to "RegionServer". 
Also this patch might result in changing these labels at other places in the ui.


Diffs
-----

  ambari-web/app/assets/data/wizard/stack/hdp/version1.3.0/HBASE.json c58ce95 
  ambari-web/app/assets/data/wizard/stack/hdp/version131/HBASE.json 6aa748b 
  ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/HBASE.json a4bd060 
  ambari-web/app/data/HDP2/global_properties.js cf5fbaf 
  ambari-web/app/data/HDP2/secure_properties.js fae3623 
  ambari-web/app/data/HDP2/site_properties.js 448621a 
  ambari-web/app/data/global_properties.js 56e9831 
  ambari-web/app/data/secure_properties.js 572624f 
  ambari-web/app/data/site_properties.js fca3537 
  ambari-web/app/messages.js f939538 
  ambari-web/app/utils/helper.js 9b7297b 

Diff: https://reviews.apache.org/r/20631/diff/


Testing
-------


Thanks,

Jaimin Jetly


Re: Review Request 20631: Add Host: checkbox "client" without upper case letter

Posted by Jaimin Jetly <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20631/
-----------------------------------------------------------

(Updated April 23, 2014, 10:23 p.m.)


Review request for Ambari and Yusaku Sako.


Changes
-------

This patch replaces all occurrences of "HBase RegionServer" in the client code to "RegionServer" 


Bugs: AMBARI-5551
    https://issues.apache.org/jira/browse/AMBARI-5551


Repository: ambari


Description
-------

This patch reverts the label name "client" to "Client" and "HBase RegionServer" to "RegionServer". 
Also this patch might result in changing these labels at other places in the ui.


Diffs (updated)
-----

  ambari-web/app/assets/data/wizard/stack/hdp/version1.3.0/HBASE.json c58ce95 
  ambari-web/app/assets/data/wizard/stack/hdp/version131/HBASE.json 6aa748b 
  ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/HBASE.json a4bd060 
  ambari-web/app/data/HDP2/global_properties.js cf5fbaf 
  ambari-web/app/data/HDP2/secure_properties.js fae3623 
  ambari-web/app/data/HDP2/site_properties.js 448621a 
  ambari-web/app/data/global_properties.js 56e9831 
  ambari-web/app/data/secure_properties.js 572624f 
  ambari-web/app/data/site_properties.js fca3537 
  ambari-web/app/messages.js f939538 
  ambari-web/app/utils/helper.js 9b7297b 

Diff: https://reviews.apache.org/r/20631/diff/


Testing
-------


File Attachments
----------------

updated patch
  https://reviews.apache.org/media/uploaded/files/2014/04/23/36221b51-94d4-4c75-9401-884f77069104__AMBARI-5551_2.patch


Thanks,

Jaimin Jetly


Re: Review Request 20631: Add Host: checkbox "client" without upper case letter

Posted by Jaimin Jetly <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20631/
-----------------------------------------------------------

(Updated April 23, 2014, 10:20 p.m.)


Review request for Ambari and Yusaku Sako.


Changes
-------

This patch replaces all occurrences of "HBase RegionServer" in the client code to "RegionServer"


Bugs: AMBARI-5551
    https://issues.apache.org/jira/browse/AMBARI-5551


Repository: ambari


Description
-------

This patch reverts the label name "client" to "Client" and "HBase RegionServer" to "RegionServer". 
Also this patch might result in changing these labels at other places in the ui.


Diffs
-----

  ambari-web/app/utils/helper.js 9b7297b 

Diff: https://reviews.apache.org/r/20631/diff/


Testing
-------


File Attachments (updated)
----------------

updated patch
  https://reviews.apache.org/media/uploaded/files/2014/04/23/36221b51-94d4-4c75-9401-884f77069104__AMBARI-5551_2.patch


Thanks,

Jaimin Jetly