You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/01/29 17:45:08 UTC

[GitHub] jai1 commented on a change in pull request #1124: Support Pulsar proxy from C++/Python client library

jai1 commented on a change in pull request #1124: Support Pulsar proxy from C++/Python client library
URL: https://github.com/apache/incubator-pulsar/pull/1124#discussion_r164505748
 
 

 ##########
 File path: pulsar-client-cpp/lib/Url.cc
 ##########
 @@ -88,6 +88,12 @@ const std::string& Url::file() const { return file_; }
 
 const std::string& Url::parameter() const { return parameter_; }
 
+std::string Url::hostPort() const {
 
 Review comment:
   How returning const reference:-
   const std::string& hostPort() const;

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services