You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/21 03:53:49 UTC
[GitHub] [shardingsphere] gxxiong opened a new pull request, #22304: merge EncryptEqualCondition and EncryptLikeCondition to EncryptBinaryCondition
gxxiong opened a new pull request, #22304:
URL: https://github.com/apache/shardingsphere/pull/22304
Ref #22098.
Changes proposed in this pull request:
-merge EncryptEqualCondition and EncryptLikeCondition to EncryptBinaryCondition
---
Before committing this PR, I'm sure that I have checked the following options:
- [X] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [X] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [X] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22304: merge EncryptEqualCondition and EncryptLikeCondition to EncryptBinaryCondition
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22304:
URL: https://github.com/apache/shardingsphere/pull/22304#issuecomment-1321455016
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22304?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22304](https://codecov.io/gh/apache/shardingsphere/pull/22304?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (594d163) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0160f941322ddede730f3acc6b8cea8cae153940?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0160f94) will **increase** coverage by `0.02%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #22304 +/- ##
============================================
+ Coverage 51.05% 51.07% +0.02%
Complexity 2506 2506
============================================
Files 4157 4156 -1
Lines 57685 57663 -22
Branches 9785 9782 -3
============================================
+ Hits 29451 29452 +1
+ Misses 25702 25679 -23
Partials 2532 2532
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...er/rewriter/EncryptPredicateParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/22304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvcGFyYW1ldGVyL3Jld3JpdGVyL0VuY3J5cHRQcmVkaWNhdGVQYXJhbWV0ZXJSZXdyaXRlci5qYXZh) | `4.54% <0.00%> (-0.22%)` | :arrow_down: |
| [...ator/EncryptPredicateRightValueTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/22304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL0VuY3J5cHRQcmVkaWNhdGVSaWdodFZhbHVlVG9rZW5HZW5lcmF0b3IuamF2YQ==) | `53.84% <0.00%> (ø)` | |
| [...rypt/rewrite/condition/EncryptConditionEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/22304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvY29uZGl0aW9uL0VuY3J5cHRDb25kaXRpb25FbmdpbmUuamF2YQ==) | `58.33% <66.66%> (+1.35%)` | :arrow_up: |
| [...rewrite/condition/impl/EncryptBinaryCondition.java](https://codecov.io/gh/apache/shardingsphere/pull/22304/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvY29uZGl0aW9uL2ltcGwvRW5jcnlwdEJpbmFyeUNvbmRpdGlvbi5qYXZh) | `60.86% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #22304: merge EncryptEqualCondition and EncryptLikeCondition to EncryptBinaryCondition
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #22304:
URL: https://github.com/apache/shardingsphere/pull/22304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org