[kudu-CR] [test] handle ScanTableToStrings() result status

["Yingchun Lai (Code Review)" <ge...@cloudera.org>]

Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/11825 )

Change subject: [test] handle ScanTableToStrings() result status
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11825/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

http://gerrit.cloudera.org:8080/#/c/11825/2/src/kudu/client/client-test.cc@3523
PS2, Line 3523:     ASSERT_OK(ScanTableToStrings(client_table_.get(), &rows));
Some other place use two ASSERT, compare with rows.size() and rows[0], could you unify them in the same style?


http://gerrit.cloudera.org:8080/#/c/11825/2/src/kudu/integration-tests/alter_table-test.cc
File src/kudu/integration-tests/alter_table-test.cc:

http://gerrit.cloudera.org:8080/#/c/11825/2/src/kudu/integration-tests/alter_table-test.cc@694
PS2, Line 694:   std::sort(rows->begin(), rows->end());
Seems many place will sort rows after ScanTableToStrings, how about wrap it into the function?



-- 
To view, visit http://gerrit.cloudera.org:8080/11825
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97a68f4c3ba5041848adddbefeb22e64b42a2745
Gerrit-Change-Number: 11825
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Fri, 26 Jul 2019 00:15:57 +0000
Gerrit-HasComments: Yes