You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Erik Bergenholtz <eb...@hortonworks.com> on 2015/06/11 06:12:36 UTC
Review Request 35346: Disable delete button when applicable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35346/
-----------------------------------------------------------
Review request for Ambari, Robert Levas and Tom Beerbower.
Bugs: AMBARI-11856
https://issues.apache.org/jira/browse/AMBARI-11856
Repository: ambari
Description
-------
If a user does not have permission to delete file/dir this patch doesn't show the control
Diffs
-----
contrib/views/files/src/main/resources/ui/app/components/confirmDelete.js 59394c7
contrib/views/files/src/main/resources/ui/app/components/mkdirInput.js c97f8d4
contrib/views/files/src/main/resources/ui/app/components/toggleContext.js 31f1e27
contrib/views/files/src/main/resources/ui/app/controllers/file.js ce11923
contrib/views/files/src/main/resources/ui/app/controllers/files.js f6432d1
contrib/views/files/src/main/resources/ui/app/controllers/filesAlert.js 100c5b3
contrib/views/files/src/main/resources/ui/app/initialize.js 43300f4
contrib/views/files/src/main/resources/ui/app/routes/file.js e233ea9
contrib/views/files/src/main/resources/ui/app/templates/components/contextMenu.hbs 6758b48
contrib/views/files/src/main/resources/ui/app/templates/components/mkdirInput.hbs 171b445
contrib/views/files/src/main/resources/ui/app/templates/error.hbs 577e523
contrib/views/files/src/main/resources/ui/app/templates/files.hbs 26ee096
contrib/views/files/src/main/resources/ui/app/templates/util/errorRow.hbs 45264c8
contrib/views/files/src/main/resources/ui/app/templates/util/fileRow.hbs 6ca3369
contrib/views/files/src/main/resources/ui/config.coffee e37c0f2
Diff: https://reviews.apache.org/r/35346/diff/
Testing
-------
built and deployed view to ensure delete button doesn't show for files/dirs based on permission by user.
Thanks,
Erik Bergenholtz
Re: Review Request 35346: Disable delete button when applicable
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35346/#review87565
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On June 11, 2015, 12:12 a.m., Erik Bergenholtz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35346/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 12:12 a.m.)
>
>
> Review request for Ambari, Robert Levas and Tom Beerbower.
>
>
> Bugs: AMBARI-11856
> https://issues.apache.org/jira/browse/AMBARI-11856
>
>
> Repository: ambari
>
>
> Description
> -------
>
> If a user does not have permission to delete file/dir this patch doesn't show the control
>
>
> Diffs
> -----
>
> contrib/views/files/src/main/resources/ui/app/components/confirmDelete.js 59394c7
> contrib/views/files/src/main/resources/ui/app/components/mkdirInput.js c97f8d4
> contrib/views/files/src/main/resources/ui/app/components/toggleContext.js 31f1e27
> contrib/views/files/src/main/resources/ui/app/controllers/file.js ce11923
> contrib/views/files/src/main/resources/ui/app/controllers/files.js f6432d1
> contrib/views/files/src/main/resources/ui/app/controllers/filesAlert.js 100c5b3
> contrib/views/files/src/main/resources/ui/app/initialize.js 43300f4
> contrib/views/files/src/main/resources/ui/app/routes/file.js e233ea9
> contrib/views/files/src/main/resources/ui/app/templates/components/contextMenu.hbs 6758b48
> contrib/views/files/src/main/resources/ui/app/templates/components/mkdirInput.hbs 171b445
> contrib/views/files/src/main/resources/ui/app/templates/error.hbs 577e523
> contrib/views/files/src/main/resources/ui/app/templates/files.hbs 26ee096
> contrib/views/files/src/main/resources/ui/app/templates/util/errorRow.hbs 45264c8
> contrib/views/files/src/main/resources/ui/app/templates/util/fileRow.hbs 6ca3369
> contrib/views/files/src/main/resources/ui/config.coffee e37c0f2
>
> Diff: https://reviews.apache.org/r/35346/diff/
>
>
> Testing
> -------
>
> built and deployed view to ensure delete button doesn't show for files/dirs based on permission by user.
>
>
> Thanks,
>
> Erik Bergenholtz
>
>
Re: Review Request 35346: Disable delete button when applicable
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35346/#review87559
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On June 11, 2015, 4:12 a.m., Erik Bergenholtz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35346/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 4:12 a.m.)
>
>
> Review request for Ambari, Robert Levas and Tom Beerbower.
>
>
> Bugs: AMBARI-11856
> https://issues.apache.org/jira/browse/AMBARI-11856
>
>
> Repository: ambari
>
>
> Description
> -------
>
> If a user does not have permission to delete file/dir this patch doesn't show the control
>
>
> Diffs
> -----
>
> contrib/views/files/src/main/resources/ui/app/components/confirmDelete.js 59394c7
> contrib/views/files/src/main/resources/ui/app/components/mkdirInput.js c97f8d4
> contrib/views/files/src/main/resources/ui/app/components/toggleContext.js 31f1e27
> contrib/views/files/src/main/resources/ui/app/controllers/file.js ce11923
> contrib/views/files/src/main/resources/ui/app/controllers/files.js f6432d1
> contrib/views/files/src/main/resources/ui/app/controllers/filesAlert.js 100c5b3
> contrib/views/files/src/main/resources/ui/app/initialize.js 43300f4
> contrib/views/files/src/main/resources/ui/app/routes/file.js e233ea9
> contrib/views/files/src/main/resources/ui/app/templates/components/contextMenu.hbs 6758b48
> contrib/views/files/src/main/resources/ui/app/templates/components/mkdirInput.hbs 171b445
> contrib/views/files/src/main/resources/ui/app/templates/error.hbs 577e523
> contrib/views/files/src/main/resources/ui/app/templates/files.hbs 26ee096
> contrib/views/files/src/main/resources/ui/app/templates/util/errorRow.hbs 45264c8
> contrib/views/files/src/main/resources/ui/app/templates/util/fileRow.hbs 6ca3369
> contrib/views/files/src/main/resources/ui/config.coffee e37c0f2
>
> Diff: https://reviews.apache.org/r/35346/diff/
>
>
> Testing
> -------
>
> built and deployed view to ensure delete button doesn't show for files/dirs based on permission by user.
>
>
> Thanks,
>
> Erik Bergenholtz
>
>