You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cayenne.apache.org by "Andrus Adamchik (JIRA)" <de...@cayenne.apache.org> on 2008/05/14 13:51:52 UTC
[jira] Created: (CAY-1056) Detection of the project file changes on
disk.
Detection of the project file changes on disk.
----------------------------------------------
Key: CAY-1056
URL: https://issues.apache.org/cayenne/browse/CAY-1056
Project: Cayenne
Issue Type: Improvement
Components: CayenneModeler GUI
Affects Versions: 3.0
Reporter: Andrus Adamchik
Assignee: Andrus Adamchik
Fix For: 3.0
Detection of the project file changes on disk. This is a Summer of Code 2008 project
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-1056) Detection of the project file changes on
disk.
Posted by "Andrey Razumovsky (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Razumovsky updated CAY-1056:
-----------------------------------
Attachment: patch-CAY-1056-3.txt
Hmm.. It could not go behind the scenes because SaveAs was always invoked.. Now Save is always invoked anyway, so saving is *always* behind the scenes now.
So that's patch #3.. Only 1 line has changed
> Detection of the project file changes on disk.
> ----------------------------------------------
>
> Key: CAY-1056
> URL: https://issues.apache.org/cayenne/browse/CAY-1056
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrus Adamchik
> Assignee: Andrus Adamchik
> Fix For: 3.0
>
> Attachments: patch-CAY-1056-2.txt, patch-CAY-1056-3.txt, patch-CAY-1056.txt
>
>
> Detection of the project file changes on disk. This is a Summer of Code 2008 project
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAY-1056) Detection of the project file changes
on disk.
Posted by "Andrus Adamchik (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871#action_12871 ]
Andrus Adamchik commented on CAY-1056:
--------------------------------------
Patch #2 applied... Works very nice. I found only one scenario where the behavior is a bit unpredictable:
Open a project with a single DataMap
Delete that DataMap XML on the filesystem
When modeler prompts to react to the file change, click "Save"...
Here instead of saving in the old place, Modeler pops up a file selection dialog to chose where to save the project. Strangely, when I do the same thing to cayenne.xml, saving just works behind the scenes.
> Detection of the project file changes on disk.
> ----------------------------------------------
>
> Key: CAY-1056
> URL: https://issues.apache.org/cayenne/browse/CAY-1056
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrus Adamchik
> Assignee: Andrus Adamchik
> Fix For: 3.0
>
> Attachments: patch-CAY-1056-2.txt, patch-CAY-1056.txt
>
>
> Detection of the project file changes on disk. This is a Summer of Code 2008 project
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-1056) Detection of the project file changes on
disk.
Posted by "Andrey Razumovsky (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Razumovsky updated CAY-1056:
-----------------------------------
Attachment: patch-CAY-1056.txt
Implementation of the feature
> Detection of the project file changes on disk.
> ----------------------------------------------
>
> Key: CAY-1056
> URL: https://issues.apache.org/cayenne/browse/CAY-1056
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrus Adamchik
> Assignee: Andrus Adamchik
> Fix For: 3.0
>
> Attachments: patch-CAY-1056.txt
>
>
> Detection of the project file changes on disk. This is a Summer of Code 2008 project
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (CAY-1056) Detection of the project file changes on
disk.
Posted by "Andrus Adamchik (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrus Adamchik closed CAY-1056.
--------------------------------
Resolution: Fixed
Everyting works. Thanks!
> Detection of the project file changes on disk.
> ----------------------------------------------
>
> Key: CAY-1056
> URL: https://issues.apache.org/cayenne/browse/CAY-1056
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrus Adamchik
> Assignee: Andrus Adamchik
> Fix For: 3.0
>
> Attachments: patch-CAY-1056-2.txt, patch-CAY-1056-3.txt, patch-CAY-1056.txt
>
>
> Detection of the project file changes on disk. This is a Summer of Code 2008 project
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAY-1056) Detection of the project file changes
on disk.
Posted by "Andrey Razumovsky (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860#action_12860 ]
Andrey Razumovsky commented on CAY-1056:
----------------------------------------
Second patch contains minor additions.
1. Everything worked for deletion, but only main file (cayenne.xml). I removed that checking
2. Done
> Detection of the project file changes on disk.
> ----------------------------------------------
>
> Key: CAY-1056
> URL: https://issues.apache.org/cayenne/browse/CAY-1056
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrus Adamchik
> Assignee: Andrus Adamchik
> Fix For: 3.0
>
> Attachments: patch-CAY-1056-2.txt, patch-CAY-1056.txt
>
>
> Detection of the project file changes on disk. This is a Summer of Code 2008 project
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-1056) Detection of the project file changes on
disk.
Posted by "Andrey Razumovsky (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Razumovsky updated CAY-1056:
-----------------------------------
Attachment: patch-CAY-1056-2.txt
> Detection of the project file changes on disk.
> ----------------------------------------------
>
> Key: CAY-1056
> URL: https://issues.apache.org/cayenne/browse/CAY-1056
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrus Adamchik
> Assignee: Andrus Adamchik
> Fix For: 3.0
>
> Attachments: patch-CAY-1056-2.txt, patch-CAY-1056.txt
>
>
> Detection of the project file changes on disk. This is a Summer of Code 2008 project
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAY-1056) Detection of the project file changes
on disk.
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Menard reassigned CAY-1056:
---------------------------------
Assignee: Kevin Menard (was: Andrus Adamchik)
> Detection of the project file changes on disk.
> ----------------------------------------------
>
> Key: CAY-1056
> URL: https://issues.apache.org/cayenne/browse/CAY-1056
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrus Adamchik
> Assignee: Kevin Menard
> Fix For: 3.0
>
> Attachments: patch-CAY-1056-2.txt, patch-CAY-1056.txt
>
>
> Detection of the project file changes on disk. This is a Summer of Code 2008 project
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAY-1056) Detection of the project file changes
on disk.
Posted by "Andrus Adamchik (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858#action_12858 ]
Andrus Adamchik commented on CAY-1056:
--------------------------------------
The patch applied (I reformatted the code a bit and tweaked some rather minor things like thread name and scan delay). Works nicely for modified files. Two things:
1. If a file is deleted, it is simply removed from the watch. I get no message.
2. One small improvement - when the user selects "No" to update, we should change the project state to "dirty" so that the user sees that there is a mismatch between the local state and the saved files
> Detection of the project file changes on disk.
> ----------------------------------------------
>
> Key: CAY-1056
> URL: https://issues.apache.org/cayenne/browse/CAY-1056
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrus Adamchik
> Assignee: Andrus Adamchik
> Fix For: 3.0
>
> Attachments: patch-CAY-1056.txt
>
>
> Detection of the project file changes on disk. This is a Summer of Code 2008 project
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAY-1056) Detection of the project file changes
on disk.
Posted by "Andrus Adamchik (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrus Adamchik reassigned CAY-1056:
------------------------------------
Assignee: Andrus Adamchik (was: Kevin Menard)
> Detection of the project file changes on disk.
> ----------------------------------------------
>
> Key: CAY-1056
> URL: https://issues.apache.org/cayenne/browse/CAY-1056
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrus Adamchik
> Assignee: Andrus Adamchik
> Fix For: 3.0
>
> Attachments: patch-CAY-1056-2.txt, patch-CAY-1056.txt
>
>
> Detection of the project file changes on disk. This is a Summer of Code 2008 project
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAY-1056) Detection of the project file changes
on disk.
Posted by "Kevin Menard (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865#action_12865 ]
Kevin Menard commented on CAY-1056:
-----------------------------------
Andrus, since you were actively making changes to this, would you like to take the issue back? Otherwise, I can work with Andrey on it.
> Detection of the project file changes on disk.
> ----------------------------------------------
>
> Key: CAY-1056
> URL: https://issues.apache.org/cayenne/browse/CAY-1056
> Project: Cayenne
> Issue Type: Improvement
> Components: CayenneModeler GUI
> Affects Versions: 3.0
> Reporter: Andrus Adamchik
> Assignee: Kevin Menard
> Fix For: 3.0
>
> Attachments: patch-CAY-1056-2.txt, patch-CAY-1056.txt
>
>
> Detection of the project file changes on disk. This is a Summer of Code 2008 project
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.