You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Myroslav Papirkovskyy <mp...@hortonworks.com> on 2014/05/05 14:49:50 UTC
Re: Review Request 20609: Deleted slave components stick around from the
service's perspective
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20609/#review42143
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
<https://reviews.apache.org/r/20609/#comment75867>
Dependency to AMCI in low level class looks completely wrong for me. We should move action creation logic to place where host components are removed in AMCI.
org/apache/ambari/server/controller/AmbariManagementControllerImpl.java:2160
- Myroslav Papirkovskyy
On April 30, 2014, 2:36 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20609/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 2:36 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.
>
>
> Bugs: AMBARI-5544 and AMBARI-5589
> https://issues.apache.org/jira/browse/AMBARI-5544
> https://issues.apache.org/jira/browse/AMBARI-5589
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We should set the state to INIT when the last host component gets removed
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 42c7aa9
> ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java aba2f62
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java d4083cc
>
> Diff: https://reviews.apache.org/r/20609/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [3.651s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.350s]
> [INFO] Ambari Web ........................................ SUCCESS [8.150s]
> [INFO] Ambari Views ...................................... SUCCESS [7.956s]
> [INFO] Ambari Server ..................................... SUCCESS [12:29.721s]
> [INFO] Ambari Agent ...................................... SUCCESS [29.804s]
> [INFO] Ambari Client ..................................... SUCCESS [0.562s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:23.772s
> [INFO] Finished at: Wed Apr 23 17:13:04 FET 2014
> [INFO] Final Memory: 27M/262M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>