You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/11/02 20:04:50 UTC
Review Request 39869: Added provisioner TestStore.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39869/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Jojy Varghese.
Repository: mesos
Description
-------
Added provisioner TestStore.
Diffs
-----
src/tests/containerizer/store.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/39869/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 39869: Added provisioner TestStore.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39869/
-----------------------------------------------------------
(Updated Nov. 4, 2015, 9:03 p.m.)
Review request for mesos, Jie Yu and Jojy Varghese.
Repository: mesos
Description
-------
Added provisioner TestStore.
Diffs (updated)
-----
src/tests/containerizer/store.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/39869/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 39869: Added provisioner TestStore.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39869/#review104840
-----------------------------------------------------------
Ship it!
src/tests/containerizer/store.hpp (line 80)
<https://reviews.apache.org/r/39869/#comment163105>
Add parathesis around initializing list:
```
return vector<string>({rootfs.get()->root});
```
- Jie Yu
On Nov. 2, 2015, 7:04 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39869/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 7:04 p.m.)
>
>
> Review request for mesos, Jie Yu and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added provisioner TestStore.
>
>
> Diffs
> -----
>
> src/tests/containerizer/store.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39869/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>