You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by stigsb <gi...@git.apache.org> on 2016/01/22 07:31:46 UTC
[GitHub] thrift pull request: THRIFT-3574 Cocoa: use the right namespace fo...
GitHub user stigsb opened a pull request:
https://github.com/apache/thrift/pull/812
THRIFT-3574 Cocoa: use the right namespace for included generated .h files
The Cocoa generator currently uses the namespace of the including file in imports statements, instead of the included file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stigsb/thrift cocoa_imports_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/812.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #812
----
commit e4994d9372b9bcda18eb5bcc00ce3c74bfb72179
Author: Stig Bakken <st...@zedge.net>
Date: 2016-01-22T06:23:55Z
Cocoa: use the right namespace for included generated .h files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3574 Cocoa: use the right namespace fo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/812
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3574 Cocoa: use the right namespace fo...
Posted by kdubb <gi...@git.apache.org>.
Github user kdubb commented on the pull request:
https://github.com/apache/thrift/pull/812#issuecomment-174015927
This fix looks correct. Out of curiosity does it work with Pods frameworks option? I assume it will since you are just including another project file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3574 Cocoa: use the right namespace fo...
Posted by stigsb <gi...@git.apache.org>.
Github user stigsb commented on the pull request:
https://github.com/apache/thrift/pull/812#issuecomment-174049066
@kdubb yes, we are using the pods option
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---