You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2006/07/23 13:38:55 UTC
svn commit: r424721 - in /james/server/trunk/src:
java/org/apache/james/smtpserver/core/RoaminUsersHandler.java
java/org/apache/james/util/RoaminUsersHelper.java
test/org/apache/james/smtpserver/RoaminUsersHandlerTest.java
Author: norman
Date: Sun Jul 23 04:38:54 2006
New Revision: 424721
URL: http://svn.apache.org/viewvc?rev=424721&view=rev
Log:
Some code improvments and a new junit test
Modified:
james/server/trunk/src/java/org/apache/james/smtpserver/core/RoaminUsersHandler.java
james/server/trunk/src/java/org/apache/james/util/RoaminUsersHelper.java
james/server/trunk/src/test/org/apache/james/smtpserver/RoaminUsersHandlerTest.java
Modified: james/server/trunk/src/java/org/apache/james/smtpserver/core/RoaminUsersHandler.java
URL: http://svn.apache.org/viewvc/james/server/trunk/src/java/org/apache/james/smtpserver/core/RoaminUsersHandler.java?rev=424721&r1=424720&r2=424721&view=diff
==============================================================================
--- james/server/trunk/src/java/org/apache/james/smtpserver/core/RoaminUsersHandler.java (original)
+++ james/server/trunk/src/java/org/apache/james/smtpserver/core/RoaminUsersHandler.java Sun Jul 23 04:38:54 2006
@@ -69,7 +69,7 @@
public void onConnect(SMTPSession session) {
// some kind of random cleanup process
- if (Math.random() > 0.8) {
+ if (Math.random() > 0.99) {
RoaminUsersHelper.removeExpiredIP(expireTime);
}
Modified: james/server/trunk/src/java/org/apache/james/util/RoaminUsersHelper.java
URL: http://svn.apache.org/viewvc/james/server/trunk/src/java/org/apache/james/util/RoaminUsersHelper.java?rev=424721&r1=424720&r2=424721&view=diff
==============================================================================
--- james/server/trunk/src/java/org/apache/james/util/RoaminUsersHelper.java (original)
+++ james/server/trunk/src/java/org/apache/james/util/RoaminUsersHelper.java Sun Jul 23 04:38:54 2006
@@ -46,12 +46,7 @@
* @return true if authorized. Else false
*/
public static synchronized boolean isAuthorized(String ipAddress) {
-
- if (ipMap.containsKey(ipAddress)) {
- return true;
-
- }
- return false;
+ return ipMap.containsKey(ipAddress);
}
/**
Modified: james/server/trunk/src/test/org/apache/james/smtpserver/RoaminUsersHandlerTest.java
URL: http://svn.apache.org/viewvc/james/server/trunk/src/test/org/apache/james/smtpserver/RoaminUsersHandlerTest.java?rev=424721&r1=424720&r2=424721&view=diff
==============================================================================
--- james/server/trunk/src/test/org/apache/james/smtpserver/RoaminUsersHandlerTest.java (original)
+++ james/server/trunk/src/test/org/apache/james/smtpserver/RoaminUsersHandlerTest.java Sun Jul 23 04:38:54 2006
@@ -220,4 +220,20 @@
//ignore
}
}
+
+ public void testThrowException() {
+ boolean exception = false;
+ RoaminUsersHandler handler = new RoaminUsersHandler();
+
+ ContainerUtil.enableLogging(handler, new MockLogger());
+ setupMockedSMTPSession();
+
+ try {
+ handler.setExpireTime("1 unit");
+ } catch (NumberFormatException e) {
+ exception = true;
+ }
+ assertTrue(exception);
+ }
+
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org