You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/15 13:57:48 UTC
[GitHub] [apisix-dashboard] bisakhmondal opened a new pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
bisakhmondal opened a new pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Please update this section with detailed description.
**Related issues**
#1500
**Checklist:**
- [ ] Did you explain what problem does this PR solve? Or what new features have been added?
- [x] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-820443115
Deploy preview for *apisix-dashboard* ready!
Built with commit a559218e471af77eb1e6b14df76ac4361406f09f
https://deploy-preview-1781--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-821807944
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1781?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1781](https://codecov.io/gh/apache/apisix-dashboard/pull/1781?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (802368a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1d2bc545c6e081f9ce0270ae12d61eecdaadab0e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1d2bc54) will **decrease** coverage by `19.90%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1781 +/- ##
===========================================
- Coverage 72.13% 52.23% -19.91%
===========================================
Files 132 38 -94
Lines 5721 2661 -3060
Branches 649 0 -649
===========================================
- Hits 4127 1390 -2737
+ Misses 1350 1083 -267
+ Partials 244 188 -56
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `52.23% <ø> (-0.06%)` | :arrow_down: |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1781/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1781/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1781/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1781/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1781/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1781/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1781/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1781/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
| [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1781/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: |
| [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1781/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| ... and [118 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1781/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1781?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1781?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1d2bc54...802368a](https://codecov.io/gh/apache/apisix-dashboard/pull/1781?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-820443115
Deploy preview for *apisix-dashboard* ready!
Built with commit 802368a193e9dff5527ba3ef443e46c9333e9e61
https://deploy-preview-1781--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-820443115
Deploy preview for *apisix-dashboard* processing.
Building with commit ce46ff11dec4321771dd349c7dd4b6af612db50b
https://app.netlify.com/sites/apisix-dashboard/deploys/607867094dc640000822cc4a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-820443115
Deploy preview for *apisix-dashboard* processing.
Building with commit a559218e471af77eb1e6b14df76ac4361406f09f
https://app.netlify.com/sites/apisix-dashboard/deploys/607c37f9b9dc940008ac5d6a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-823052019
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-820443115
Deploy preview for *apisix-dashboard* processing.
Building with commit 4f19323a9a0a4916e32c270045614274622bbcca
https://app.netlify.com/sites/apisix-dashboard/deploys/60784654a13b6300086772e7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-821807720
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal closed pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
Posted by GitBox <gi...@apache.org>.
bisakhmondal closed pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-821801262
@bisakhmondal
please push a new commit to trigger ci, if fail again, I think we may need to create a new PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-820443115
Deploy preview for *apisix-dashboard* ready!
Built with commit ce46ff11dec4321771dd349c7dd4b6af612db50b
https://deploy-preview-1781--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-820443115
Deploy preview for *apisix-dashboard* processing.
Building with commit 802368a193e9dff5527ba3ef443e46c9333e9e61
https://app.netlify.com/sites/apisix-dashboard/deploys/607ac4a95280c600073ded03
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-822345556
hi @bisakhmondal
I think you could try to create a new PR to resolve `Expected`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-821963150
@bisakhmondal Hi, please sync codes to your branch, the FE CI will get fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-821583943
@nic-chen same pending here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-821807944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1781:
URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-820443115
Deploy preview for *apisix-dashboard* ready!
Built with commit 4f19323a9a0a4916e32c270045614274622bbcca
https://deploy-preview-1781--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org