You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/03/19 05:12:06 UTC

[GitHub] spark pull request #20798: [SPARK-23645][MINOR][DOCS][PYTHON] Add docs RE `p...

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20798#discussion_r175332763
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -2155,6 +2155,8 @@ def udf(f=None, returnType=StringType()):
             in boolean expressions and it ends up with being executed all internally. If the functions
             can fail on special rows, the workaround is to incorporate the condition into the functions.
     
    +    .. note:: The user-defined functions may not take keyword arguments.
    --- End diff --
    
    I think it's fine to say`may not take` -> `does not take`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org