You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2019/09/12 22:09:35 UTC
[GitHub] [hive] jcamachor commented on a change in pull request #768:
HIVE-22188 Clean up the SemanticAnalyzerFactory
jcamachor commented on a change in pull request #768: HIVE-22188 Clean up the SemanticAnalyzerFactory
URL: https://github.com/apache/hive/pull/768#discussion_r323967929
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
##########
@@ -342,33 +342,41 @@ public void analyzeInternal(ASTNode input) throws SemanticException {
analyzeAlterTableProps(qualified, null, ast, false, false);
} else if (ast.getType() == HiveParser.TOK_ALTERTABLE_DROPPROPERTIES) {
analyzeAlterTableProps(qualified, null, ast, false, true);
- } else if (ast.getType() == HiveParser.TOK_ALTERTABLE_UPDATESTATS) {
+ } else if (ast.getType() == HiveParser.TOK_ALTERTABLE_UPDATESTATS ||
Review comment:
We could make this a _switch_ statement too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org