You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/07 19:30:47 UTC
[GitHub] [incubator-nuttx] electron101 commented on pull request #5439: Test/i2c
electron101 commented on pull request #5439:
URL: https://github.com/apache/incubator-nuttx/pull/5439#issuecomment-1031839099
Do I need any other action to merge?
пн, 7 февр. 2022 г. в 21:02, Xiang Xiao ***@***.***>:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In boards/arm/stm32/nucleo-l152re/include/board.h
> <https://github.com/apache/incubator-nuttx/pull/5439#discussion_r800921242>
> :
>
> > @@ -226,6 +226,4 @@
> #define GPIO_I2C1_SCL GPIO_I2C1_SCL_2 /* PB8 CN5 pin 10, D15 */
> #define GPIO_I2C1_SDA GPIO_I2C1_SDA_2 /* PB9 CN5 pin 9, D14 */
>
> -/* I2C2 */
> -
>
> let's merge the last two patch to the previous related patch instead.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-nuttx/pull/5439#pullrequestreview-875057811>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACPULO6GJQBZB66347B7METU2ACLDANCNFSM5NXUHWJA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org