You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by svarnau <gi...@git.apache.org> on 2016/04/12 00:14:16 UTC
[GitHub] incubator-trafodion pull request: [TRAFODION-1924] Add license/not...
GitHub user svarnau opened a pull request:
https://github.com/apache/incubator-trafodion/pull/425
[TRAFODION-1924] Add license/notice files to jdbc driver jars
This will allow distribution of jars directly via maven repos.
Also fix build-time sqenvcom.sh issue. The default empty variables
of APACHE_*_HOME caused existence check of /lib directory, which of
course always exists. Changed default location to "None", so we do
not falsely think we have hbase and query it for classpath.
Removed error checks, since it is fine in the build case to not have those
components.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/svarnau/incubator-trafodion lic1924
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/425.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #425
----
commit 9f2c663ac96b44c9f39fb59e0085cb75edbf461f
Author: Steve Varnau <sv...@apache.org>
Date: 2016-04-11T21:44:48Z
[TRAFODION-1924] Add license/notice files to jdbc driver jars
This will allow distribution of jars directly via maven repos.
Also fix build-time sqenvcom.sh issue. The default empty variables
of APACHE_*_HOME caused existence check of /lib directory, which of
course always exists. Changed default location to "None", so we do
not falsely think we have hbase and query it for classpath.
Removed error checks, since it is fine in the build case to not have those
components.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1924] Add license/not...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/425
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---