You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/23 15:23:25 UTC
[jira] [Commented] (CB-10937) Icons are more than stretched since
cordova-android 5.1.0
[ https://issues.apache.org/jira/browse/CB-10937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208478#comment-15208478 ]
ASF GitHub Bot commented on CB-10937:
-------------------------------------
GitHub user akofman opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/157
CB-10937 fix stretched icons
As mentioned in the issue. Depending on the Theme configured from cordova-android, buttons can be stretched.
I did a fix using ImageButtons instead to prevent that.
Thanks for your reviews !
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/akofman/cordova-plugin-inappbrowser master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/157.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #157
----
----
> Icons are more than stretched since cordova-android 5.1.0
> ---------------------------------------------------------
>
> Key: CB-10937
> URL: https://issues.apache.org/jira/browse/CB-10937
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin InAppBrowser
> Environment: android
> Reporter: Alexis Kofman
> Labels: android, inappbrowser
>
> Since cordova-android@5.0.1 and more especially this commit https://github.com/apache/cordova-android/commit/73fd9e4dfa5dffde2eb14ebd6c736ca462d1e29f, the theme has been updated.
> The inappbrowser plugin use images as background property of Button views.
> So, depending on default margin values in the Theme, background images can be stretched.
> A fix could be to use ImageButton views instead and chose a scaleType if needed.
> Here is what we have today using a version of cordova-android >= 5.1.0 :
> !https://cloud.githubusercontent.com/assets/579922/13982920/e81236c8-f0ec-11e5-9eeb-f969cba3b375.png|width=100%!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org