You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2018/03/05 22:53:31 UTC

[2/2] mesos git commit: Added a TODO to clean up the quota sorter tech debt.

Added a TODO to clean up the quota sorter tech debt.


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/8f4552e3
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/8f4552e3
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/8f4552e3

Branch: refs/heads/master
Commit: 8f4552e37a76b3eee6affa34729b29582eae4635
Parents: e7eaf0d
Author: Benjamin Mahler <bm...@apache.org>
Authored: Mon Mar 5 14:53:04 2018 -0800
Committer: Benjamin Mahler <bm...@apache.org>
Committed: Mon Mar 5 14:53:04 2018 -0800

----------------------------------------------------------------------
 src/master/allocator/mesos/hierarchical.hpp | 7 +++++++
 1 file changed, 7 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/8f4552e3/src/master/allocator/mesos/hierarchical.hpp
----------------------------------------------------------------------
diff --git a/src/master/allocator/mesos/hierarchical.hpp b/src/master/allocator/mesos/hierarchical.hpp
index 98285d2..955ae3e 100644
--- a/src/master/allocator/mesos/hierarchical.hpp
+++ b/src/master/allocator/mesos/hierarchical.hpp
@@ -507,6 +507,13 @@ protected:
   // The total cluster resources are used as the resource pool.
   process::Owned<Sorter> roleSorter;
 
+  // TODO(bmahler): Remove this in favor of either using the same sorting
+  // between satisfying guarantees and bursting above guarantees up to
+  // limits, or have a different sorting technique specifically for
+  // satisfying guarantees (e.g. MESOS-8026). This is tech debt from
+  // when a "quota role" was considered different from a "non-quota"
+  // role. However, they are the same, one just has a default quota.
+  //
   // A dedicated sorter for roles that have a non-default quota.
   // This sorter determines the order in which guarantees are allocated
   // during Level 1 of the first stage. Since only non-revocable